RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-25 12:12:47 +01:00
Code Issues Projects Releases Wiki Activity

Fix mysterious failure of SupportTests FileCheckTest.Binop

Browse Source 
The test would fail in no-asserts release builds using MSVC
for 64-bit Windows:

Unexpected error message:
TestBuffer:1:1: error: implicit format conflict between 'FOO' (%u) and '18\0' (%x), need an explicit format specifier

Error message(s) not found:
{implicit format conflict between 'FOO' (%u) and 'BAZ' (%x), need an explicit format specifier}

It seems a string from a previous test case is finding its way
into the latter one.

This doesn't reproduce on master anymore after 998709b7d, so let's
just hack around it here for the branch.
This commit is contained in:
Hans Wennborg 2020-09-28 15:35:01 +02:00
parent 8a3d6aad2f
commit 2e0afe6e1a
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
unittests/Support/FileCheckTest.cpp
View File

@ -714,6 +714,7 @@ TEST_F(FileCheckTest, Binop) {
Value = Binop.eval();
expectUndefErrors({"FOO", "BAR"}, Value.takeError());
{
// Literal + Variable has format of variable.
ExprStr = bufferize(SM, "FOO+18");
FooStr = ExprStr.take_front(3);
@ -736,6 +737,7 @@ TEST_F(FileCheckTest, Binop) {
ImplicitFormat = Binop.getImplicitFormat(SM);
ASSERT_THAT_EXPECTED(ImplicitFormat, Succeeded());
EXPECT_EQ(*ImplicitFormat, ExpressionFormat::Kind::Unsigned);
}
// Variables with different implicit format conflict.
ExprStr = bufferize(SM, "FOO+BAZ");