RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 03:02:36 +01:00
Code Issues Projects Releases Wiki Activity

[PassTimingInfo] cleanup on TimingData's Timer handling

Browse Source 
Replacing Timer* with unique_ptr<Timer> in a pass-to-timer map.
That allows to get rid of unpretty raw deletes in PassTimingInfo destructor.
Strictly cleanup, not intended to change any visible behavior.

llvm-svn: 343772
This commit is contained in:
Fedor Sergeev 2018-10-04 12:49:57 +00:00
parent f890b56408
commit 3087bc3290
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/IR/PassTimingInfo.cpp
View File

@ -28,6 +28,7 @@
#include "llvm/Support/Mutex.h"
#include "llvm/Support/Timer.h"
#include "llvm/Support/raw_ostream.h"
#include <memory>
#include <string>
using namespace llvm;
@ -56,7 +57,7 @@ public:
private:
StringMap<unsigned> PassIDCountMap; ///< Map that counts instances of passes
DenseMap<PassInstanceID, Timer *> TimingData; ///< timers for pass instances
DenseMap<PassInstanceID, std::unique_ptr<Timer>> TimingData; ///< timers for pass instances
TimerGroup TG;
public:
@ -93,8 +94,7 @@ PassTimingInfo::PassTimingInfo()
PassTimingInfo::~PassTimingInfo() {
// Deleting the timers accumulates their info into the TG member.
// Then TG member is (implicitly) deleted, actually printing the report.
for (auto &I : TimingData)
delete I.getSecond();
TimingData.clear();
}
void PassTimingInfo::init() {
@ -126,16 +126,16 @@ Timer *PassTimingInfo::getPassTimer(Pass *P, PassInstanceID Pass) {
init();
sys::SmartScopedLock<true> Lock(*TimingInfoMutex);
Timer *&T = TimingData[Pass];
std::unique_ptr<Timer> &T = TimingData[Pass];
if (!T) {
StringRef PassName = P->getPassName();
StringRef PassArgument;
if (const PassInfo *PI = Pass::lookupPassInfo(P->getPassID()))
PassArgument = PI->getPassArgument();
T = newPassTimer(PassArgument.empty() ? PassName : PassArgument, PassName);
T.reset(newPassTimer(PassArgument.empty() ? PassName : PassArgument, PassName));
}
return T;
return T.get();
}
PassTimingInfo *PassTimingInfo::TheTimeInfo;