RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-26 04:32:44 +01:00
Code Issues Projects Releases Wiki Activity

[CMake] Use add_dependencies in add_llvm_install_targets

Browse Source 
Summary:
The CMake documentation says that the `DEPENDS` field of
add_custom_target is for files and output of custom commands. Adding a
dependency on a target should be done with `add_dependency`.

Differential Revision: https://reviews.llvm.org/D60879

llvm-svn: 359042
This commit is contained in:
Alex Langford 2019-04-23 21:59:07 +00:00
parent 224c48bbbe
commit 334995ba64
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
cmake/modules/AddLLVM.cmake
View File

@ -603,21 +603,35 @@ function(add_llvm_install_targets target)
set(prefix_option -DCMAKE_INSTALL_PREFIX="${ARG_PREFIX}")
endif()
set(file_dependencies)
set(target_dependencies)
foreach(dependency ${ARG_DEPENDS})
if(TARGET ${dependency})
list(APPEND target_dependencies ${dependency})
else()
list(APPEND file_dependencies ${dependency})
endif()
endforeach()
add_custom_target(${target}
DEPENDS ${ARG_DEPENDS}
DEPENDS ${file_dependencies}
COMMAND "${CMAKE_COMMAND}"
${component_option}
${prefix_option}
-P "${CMAKE_BINARY_DIR}/cmake_install.cmake"
USES_TERMINAL)
add_custom_target(${target}-stripped
DEPENDS ${ARG_DEPENDS}
DEPENDS ${file_dependencies}
COMMAND "${CMAKE_COMMAND}"
${component_option}
${prefix_option}
-DCMAKE_INSTALL_DO_STRIP=1
-P "${CMAKE_BINARY_DIR}/cmake_install.cmake"
USES_TERMINAL)
if(target_dependencies)
add_dependencies(${target} ${target_dependencies})
add_dependencies(${target}-stripped ${target_dependencies})
endif()
endfunction()
macro(add_llvm_library name)