From 337a4ae273c19fc23881c75fb92d78602a45ef08 Mon Sep 17 00:00:00 2001 From: Arnold Schwaighofer Date: Tue, 6 Jul 2021 11:26:17 -0700 Subject: [PATCH] [coro async] Move code to proper switch While upstreaming patches this code somehow was applied to the wrong switch statement. Differential Revision: https://reviews.llvm.org/D105504 --- lib/Transforms/Coroutines/CoroSplit.cpp | 32 ++++++++++++------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/lib/Transforms/Coroutines/CoroSplit.cpp b/lib/Transforms/Coroutines/CoroSplit.cpp index 402066cd36f..c73bc5df63f 100644 --- a/lib/Transforms/Coroutines/CoroSplit.cpp +++ b/lib/Transforms/Coroutines/CoroSplit.cpp @@ -913,6 +913,21 @@ void CoroCloner::create() { Shape.FrameSize, Shape.FrameAlign); break; case coro::ABI::Async: { + auto *ActiveAsyncSuspend = cast(ActiveSuspend); + if (OrigF.hasParamAttribute(Shape.AsyncLowering.ContextArgNo, + Attribute::SwiftAsync)) { + uint32_t ArgAttributeIndices = + ActiveAsyncSuspend->getStorageArgumentIndex(); + auto ContextArgIndex = ArgAttributeIndices & 0xff; + addAsyncContextAttrs(NewAttrs, Context, ContextArgIndex); + + // `swiftasync` must preceed `swiftself` so 0 is not a valid index for + // `swiftself`. + auto SwiftSelfIndex = ArgAttributeIndices >> 8; + if (SwiftSelfIndex) + addSwiftSelfAttrs(NewAttrs, Context, SwiftSelfIndex); + } + // Transfer the original function's attributes. auto FnAttrs = OrigF.getAttributes().getFnAttributes(); NewAttrs = @@ -952,24 +967,9 @@ void CoroCloner::create() { // followed by a return. // Don't change returns to unreachable because that will trip up the verifier. // These returns should be unreachable from the clone. - case coro::ABI::Async: { - auto *ActiveAsyncSuspend = cast(ActiveSuspend); - if (OrigF.hasParamAttribute(Shape.AsyncLowering.ContextArgNo, - Attribute::SwiftAsync)) { - uint32_t ArgAttributeIndices = - ActiveAsyncSuspend->getStorageArgumentIndex(); - auto ContextArgIndex = ArgAttributeIndices & 0xff; - addAsyncContextAttrs(NewAttrs, Context, ContextArgIndex); - - // `swiftasync` must preceed `swiftself` so 0 is not a valid index for - // `swiftself`. - auto SwiftSelfIndex = ArgAttributeIndices >> 8; - if (SwiftSelfIndex) - addSwiftSelfAttrs(NewAttrs, Context, SwiftSelfIndex); - } + case coro::ABI::Async: break; } - } NewF->setAttributes(NewAttrs); NewF->setCallingConv(Shape.getResumeFunctionCC());