RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-22 18:54:02 +01:00
Code Issues Projects Releases Wiki Activity

[Inliner] Assert that the computed inline threshold is non-negative.

Browse Source 
Reviewers: chandlerc

Subscribers: haicheng, llvm-commits

Differential Revision: https://reviews.llvm.org/D56409

llvm-svn: 350751
This commit is contained in:
Easwaran Raman 2019-01-09 19:26:17 +00:00
parent cd641e1e98
commit 372b240afa
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Analysis/InlineCost.cpp
View File

@ -1731,6 +1731,13 @@ InlineResult CallAnalyzer::analyzeCall(CallSite CS) {
// Update the threshold based on callsite properties
updateThreshold(CS, F);
// While Threshold depends on commandline options that can take negative
// values, we want to enforce the invariant that the computed threshold and
// bonuses are non-negative.
assert(Threshold >= 0);
assert(SingleBBBonus >= 0);
assert(VectorBonus >= 0);
// Speculatively apply all possible bonuses to Threshold. If cost exceeds
// this Threshold any time, and cost cannot decrease, we can stop processing
// the rest of the function body.

7
test/Transforms/Inline/inline-remark.ll
View File

@ -1,7 +1,9 @@
; RUN: opt < %s -inline -inline-remark-attribute --inline-threshold=-2 -S | FileCheck %s
; RUN: opt < %s -inline -inline-remark-attribute --inline-threshold=0 -S | FileCheck %s
; Test that the inliner adds inline remark attributes to non-inlined callsites.
declare void @ext();
define void @foo() {
call void @bar(i1 true)
ret void
@ -12,6 +14,7 @@ define void @bar(i1 %p) {
bb1:
call void @foo()
call void @ext()
ret void
bb2:
@ -43,6 +46,6 @@ define void @test2(i8*) {
ret void
}
; CHECK: attributes [[ATTR1]] = { "inline-remark"="(cost=-5, threshold=-6)" }
; CHECK: attributes [[ATTR1]] = { "inline-remark"="(cost=25, threshold=0)" }
; CHECK: attributes [[ATTR2]] = { "inline-remark"="(cost=never): recursive" }
; CHECK: attributes [[ATTR3]] = { "inline-remark"="unsupported operand bundle; (cost={{.*}}, threshold={{.*}})" }