diff --git a/lib/Target/CBackend/Writer.cpp b/lib/Target/CBackend/Writer.cpp index dd455821689..87a575b813c 100644 --- a/lib/Target/CBackend/Writer.cpp +++ b/lib/Target/CBackend/Writer.cpp @@ -1037,29 +1037,22 @@ void CWriter::printModuleTypes(const SymbolTable &ST) { // this one depends on. void CWriter::printContainedStructs(const Type *Ty, std::set &StructPrinted){ + // Don't walk through pointers. + if (isa(Ty) || Ty->isPrimitiveType()) return; + + // Print all contained types first. + for (Type::subtype_iterator I = Ty->subtype_begin(), + E = Ty->subtype_end(); I != E; ++I) + printContainedStructs(*I, StructPrinted); + if (const StructType *STy = dyn_cast(Ty)) { - //Check to see if we have already printed this struct - if (StructPrinted.count(STy) == 0) { - // Print all contained types first... - for (StructType::element_iterator I = STy->element_begin(), - E = STy->element_end(); I != E; ++I) { - const Type *Ty1 = I->get(); - if (isa(Ty1) || isa(Ty1)) - printContainedStructs(*I, StructPrinted); - } - - //Print structure type out.. - StructPrinted.insert(STy); + // Check to see if we have already printed this struct. + if (StructPrinted.insert(STy).second) { + // Print structure type out. std::string Name = TypeNames[STy]; printType(Out, STy, Name, true); Out << ";\n\n"; } - - // If it is an array, check contained types and continue - } else if (const ArrayType *ATy = dyn_cast(Ty)){ - const Type *Ty1 = ATy->getElementType(); - if (isa(Ty1) || isa(Ty1)) - printContainedStructs(Ty1, StructPrinted); } }