mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 02:52:53 +02:00
MCExpr: Avoid UB by evaluating this shift as unsigned
We hit undefined behaviour in some MCExpr tests when the LHS of a left shift is -1. Twos-complement semantics are completely reasonable here, so we should just do the shift in unsigned. llvm-svn: 240385
This commit is contained in:
parent
996cc0afa2
commit
394227380b
@ -752,7 +752,7 @@ bool MCExpr::evaluateAsRelocatableImpl(MCValue &Res, const MCAssembler *Asm,
|
||||
case MCBinaryExpr::Mul: Result = LHS * RHS; break;
|
||||
case MCBinaryExpr::NE: Result = LHS != RHS; break;
|
||||
case MCBinaryExpr::Or: Result = LHS | RHS; break;
|
||||
case MCBinaryExpr::Shl: Result = LHS << RHS; break;
|
||||
case MCBinaryExpr::Shl: Result = uint64_t(LHS) << uint64_t(RHS); break;
|
||||
case MCBinaryExpr::Sub: Result = LHS - RHS; break;
|
||||
case MCBinaryExpr::Xor: Result = LHS ^ RHS; break;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user