From 3baf157321b8fbee2e6cf567b18e6aeacc3fd487 Mon Sep 17 00:00:00 2001 From: Sanjiv Gupta Date: Thu, 9 Apr 2009 04:03:43 +0000 Subject: [PATCH] r68576 unconverd a bug in PIC16 port (Thanks to Dan Gohman) where we were custom lowering an ADD to ADDC. llvm-svn: 68671 --- lib/Target/PIC16/PIC16ISelLowering.cpp | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/Target/PIC16/PIC16ISelLowering.cpp b/lib/Target/PIC16/PIC16ISelLowering.cpp index c8e58a6543f..5996d886ad7 100644 --- a/lib/Target/PIC16/PIC16ISelLowering.cpp +++ b/lib/Target/PIC16/PIC16ISelLowering.cpp @@ -1359,21 +1359,26 @@ SDValue PIC16TargetLowering::LowerADD(SDValue Op, SelectionDAG &DAG) { // Put one value on stack. SDValue NewVal = ConvertToMemOperand (Op.getOperand(MemOp), DAG, dl); + // ADDC and ADDE produces two results. SDVTList Tys = DAG.getVTList(MVT::i8, MVT::Flag); + // ADDE has three operands, the last one is a flag. if (Op.getOpcode() == ISD::ADDE) return DAG.getNode(Op.getOpcode(), dl, Tys, Op.getOperand(MemOp ^ 1), NewVal, Op.getOperand(2)); - else + // ADDC has two operands. + else if (Op.getOpcode() == ISD::ADDC) return DAG.getNode(Op.getOpcode(), dl, Tys, Op.getOperand(MemOp ^ 1), NewVal); + // ADD it is. It produces only one result. + else + return DAG.getNode(Op.getOpcode(), dl, MVT::i8, Op.getOperand(MemOp ^ 1), + NewVal); } - else if (Op.getOpcode() == ISD::ADD) { + else if (Op.getOpcode() == ISD::ADD) return Op; - } - else { + else return SDValue(); - } } SDValue PIC16TargetLowering::LowerSUB(SDValue Op, SelectionDAG &DAG) {