RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 19:23:23 +01:00
Code Issues Projects Releases Wiki Activity

[DWARF] Simplify DWARFAttribute. NFC.

Browse Source 
The first argument in the constructor was ignored, and the remaining
arguments were always passed as their defaults.

Differential Revision: https://reviews.llvm.org/D64407

llvm-svn: 366188
This commit is contained in:
Igor Kudrin 2019-07-16 06:53:06 +00:00
parent 31bbc011c8
commit 3e859df823
2 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
include/llvm/DebugInfo/DWARF/DWARFAttribute.h
View File

@ -27,13 +27,10 @@ struct DWARFAttribute {
/// The debug info/types section byte size of the data for this attribute.
uint32_t ByteSize = 0;
/// The attribute enumeration of this attribute.
dwarf::Attribute Attr;
dwarf::Attribute Attr = dwarf::Attribute(0);
/// The form and value for this attribute.
DWARFFormValue Value;
DWARFAttribute(uint32_t O, dwarf::Attribute A = dwarf::Attribute(0),
dwarf::Form F = dwarf::Form(0)) : Attr(A), Value(F) {}
bool isValid() const {
return Offset != 0 && Attr != dwarf::Attribute(0);
}
@ -45,13 +42,6 @@ struct DWARFAttribute {
/// Identifies DWARF attributes that may contain a reference to a
/// DWARF expression.
static bool mayHaveLocationDescription(dwarf::Attribute Attr);
void clear() {
Offset = 0;
ByteSize = 0;
Attr = dwarf::Attribute(0);
Value = DWARFFormValue();
}
};
} // end namespace llvm

4
lib/DebugInfo/DWARF/DWARFDie.cpp
View File

@ -663,7 +663,7 @@ iterator_range<DWARFDie::attribute_iterator> DWARFDie::attributes() const {
}
DWARFDie::attribute_iterator::attribute_iterator(DWARFDie D, bool End)
: Die(D), AttrValue(0), Index(0) {
: Die(D), Index(0) {
auto AbbrDecl = Die.getAbbreviationDeclarationPtr();
assert(AbbrDecl && "Must have abbreviation declaration");
if (End) {
@ -693,7 +693,7 @@ void DWARFDie::attribute_iterator::updateForIndex(
AttrValue.ByteSize = ParseOffset - AttrValue.Offset;
} else {
assert(Index == NumAttrs && "Indexes should be [0, NumAttrs) only");
AttrValue.clear();
AttrValue = {};
}
}