RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-18 18:42:46 +02:00
Code Issues Projects Releases Wiki Activity

Cleanup else-after-return and add an early-return to llvm-nm

Browse Source 
The loop and error handling in checkMachOAndArchFlags didn't make sense
to me (a loop that only ever executes once? An error path that uses the
element the loop stopped at (which must always be a buffer overrun if
I'm reading that right?)... I'm confused) but I've made a guess at what
was intended.

Based on a patch by Richard Thomson to simplify boolean expressions.

llvm-svn: 233025
This commit is contained in:
David Blaikie 2015-03-23 21:17:43 +00:00
parent dda2ff1737
commit 3ec1353923
1 changed files with 59 additions and 71 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

130
tools/llvm-nm/llvm-nm.cpp
View File

@ -188,85 +188,77 @@ static bool compareSymbolAddress(const NMSymbol &A, const NMSymbol &B) {
if (!ReverseSort) {
if (A.Address < B.Address)
return true;
else if (A.Address == B.Address && A.Name < B.Name)
if (A.Address == B.Address && A.Name < B.Name)
return true;
else if (A.Address == B.Address && A.Name == B.Name && A.Size < B.Size)
if (A.Address == B.Address && A.Name == B.Name && A.Size < B.Size)
return true;
else
return false;
} else {
if (A.Address > B.Address)
return true;
else if (A.Address == B.Address && A.Name > B.Name)
return true;
else if (A.Address == B.Address && A.Name == B.Name && A.Size > B.Size)
return true;
else
return false;
return false;
}
if (A.Address > B.Address)
return true;
if (A.Address == B.Address && A.Name > B.Name)
return true;
if (A.Address == B.Address && A.Name == B.Name && A.Size > B.Size)
return true;
return false;
}
static bool compareSymbolSize(const NMSymbol &A, const NMSymbol &B) {
if (!ReverseSort) {
if (A.Size < B.Size)
return true;
else if (A.Size == B.Size && A.Name < B.Name)
if (A.Size == B.Size && A.Name < B.Name)
return true;
else if (A.Size == B.Size && A.Name == B.Name && A.Address < B.Address)
if (A.Size == B.Size && A.Name == B.Name && A.Address < B.Address)
return true;
else
return false;
} else {
if (A.Size > B.Size)
return true;
else if (A.Size == B.Size && A.Name > B.Name)
return true;
else if (A.Size == B.Size && A.Name == B.Name && A.Address > B.Address)
return true;
else
return false;
return false;
}
if (A.Size > B.Size)
return true;
if (A.Size == B.Size && A.Name > B.Name)
return true;
if (A.Size == B.Size && A.Name == B.Name && A.Address > B.Address)
return true;
return false;
}
static bool compareSymbolName(const NMSymbol &A, const NMSymbol &B) {
if (!ReverseSort) {
if (A.Name < B.Name)
return true;
else if (A.Name == B.Name && A.Size < B.Size)
if (A.Name == B.Name && A.Size < B.Size)
return true;
else if (A.Name == B.Name && A.Size == B.Size && A.Address < B.Address)
if (A.Name == B.Name && A.Size == B.Size && A.Address < B.Address)
return true;
else
return false;
} else {
if (A.Name > B.Name)
return true;
else if (A.Name == B.Name && A.Size > B.Size)
return true;
else if (A.Name == B.Name && A.Size == B.Size && A.Address > B.Address)
return true;
else
return false;
return false;
}
if (A.Name > B.Name)
return true;
if (A.Name == B.Name && A.Size > B.Size)
return true;
if (A.Name == B.Name && A.Size == B.Size && A.Address > B.Address)
return true;
return false;
}
static char isSymbolList64Bit(SymbolicFile &Obj) {
if (isa<IRObjectFile>(Obj))
return false;
else if (isa<COFFObjectFile>(Obj))
if (isa<COFFObjectFile>(Obj))
return false;
else if (MachOObjectFile *MachO = dyn_cast<MachOObjectFile>(&Obj))
if (MachOObjectFile *MachO = dyn_cast<MachOObjectFile>(&Obj))
return MachO->is64Bit();
else if (isa<ELF32LEObjectFile>(Obj))
if (isa<ELF32LEObjectFile>(Obj))
return false;
else if (isa<ELF64LEObjectFile>(Obj))
if (isa<ELF64LEObjectFile>(Obj))
return true;
else if (isa<ELF32BEObjectFile>(Obj))
if (isa<ELF32BEObjectFile>(Obj))
return false;
else if (isa<ELF64BEObjectFile>(Obj))
if (isa<ELF64BEObjectFile>(Obj))
return true;
else
return false;
return false;
}
static StringRef CurrentFilename;
@ -973,30 +965,26 @@ static void dumpSymbolNamesFromObject(SymbolicFile &Obj, bool printName,
// architectures was specificed. If not then an error is generated and this
// routine returns false. Else it returns true.
static bool checkMachOAndArchFlags(SymbolicFile *O, std::string &Filename) {
if (isa<MachOObjectFile>(O) && !ArchAll && ArchFlags.size() != 0) {
MachOObjectFile *MachO = dyn_cast<MachOObjectFile>(O);
bool ArchFound = false;
MachO::mach_header H;
MachO::mach_header_64 H_64;
Triple T;
if (MachO->is64Bit()) {
H_64 = MachO->MachOObjectFile::getHeader64();
T = MachOObjectFile::getArch(H_64.cputype, H_64.cpusubtype);
} else {
H = MachO->MachOObjectFile::getHeader();
T = MachOObjectFile::getArch(H.cputype, H.cpusubtype);
}
unsigned i;
for (i = 0; i < ArchFlags.size(); ++i) {
if (ArchFlags[i] == T.getArchName())
ArchFound = true;
break;
}
if (!ArchFound) {
error(ArchFlags[i],
"file: " + Filename + " does not contain architecture");
return false;
}
MachOObjectFile *MachO = dyn_cast<MachOObjectFile>(O);
if (!MachO || ArchAll || ArchFlags.size() == 0)
return true;
MachO::mach_header H;
MachO::mach_header_64 H_64;
Triple T;
if (MachO->is64Bit()) {
H_64 = MachO->MachOObjectFile::getHeader64();
T = MachOObjectFile::getArch(H_64.cputype, H_64.cpusubtype);
} else {
H = MachO->MachOObjectFile::getHeader();
T = MachOObjectFile::getArch(H.cputype, H.cpusubtype);
}
if (std::none_of(
ArchFlags.begin(), ArchFlags.end(),
[&](const std::string &Name) { return Name == T.getArchName(); })) {
error("No architecture specified", Filename);
return false;
}
return true;
}