From 414a86c35b80f64b2e9671ab7cbd531d0461e485 Mon Sep 17 00:00:00 2001 From: Eric Christopher Date: Thu, 19 Feb 2015 01:10:49 +0000 Subject: [PATCH] Remove the DisasmEnabled AsmPrinter variable and just look it up on the subtarget where it's set anyhow than looking it up 2-3 times in the same place. llvm-svn: 229802 --- lib/Target/R600/AMDGPUAsmPrinter.cpp | 6 ++---- lib/Target/R600/AMDGPUAsmPrinter.h | 1 - lib/Target/R600/AMDGPUMCInstLower.cpp | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/Target/R600/AMDGPUAsmPrinter.cpp b/lib/Target/R600/AMDGPUAsmPrinter.cpp index 4721a44e277..1c65e7e3566 100644 --- a/lib/Target/R600/AMDGPUAsmPrinter.cpp +++ b/lib/Target/R600/AMDGPUAsmPrinter.cpp @@ -86,9 +86,7 @@ extern "C" void LLVMInitializeR600AsmPrinter() { AMDGPUAsmPrinter::AMDGPUAsmPrinter(TargetMachine &TM, std::unique_ptr Streamer) - : AsmPrinter(TM, std::move(Streamer)) { - DisasmEnabled = TM.getSubtarget().dumpCode(); -} + : AsmPrinter(TM, std::move(Streamer)) {} void AMDGPUAsmPrinter::EmitEndOfAsmFile(Module &M) { @@ -160,7 +158,7 @@ bool AMDGPUAsmPrinter::runOnMachineFunction(MachineFunction &MF) { } } - if (STM.dumpCode() && DisasmEnabled) { + if (STM.dumpCode()) { OutStreamer.SwitchSection( Context.getELFSection(".AMDGPU.disasm", ELF::SHT_NOTE, 0)); diff --git a/lib/Target/R600/AMDGPUAsmPrinter.h b/lib/Target/R600/AMDGPUAsmPrinter.h index 375b3e1b4b6..58ffb1ed4ed 100644 --- a/lib/Target/R600/AMDGPUAsmPrinter.h +++ b/lib/Target/R600/AMDGPUAsmPrinter.h @@ -100,7 +100,6 @@ public: void EmitEndOfAsmFile(Module &M) override; protected: - bool DisasmEnabled; std::vector DisasmLines, HexLines; size_t DisasmLineMaxLen; }; diff --git a/lib/Target/R600/AMDGPUMCInstLower.cpp b/lib/Target/R600/AMDGPUMCInstLower.cpp index bfb36e80916..19fe2b372e5 100644 --- a/lib/Target/R600/AMDGPUMCInstLower.cpp +++ b/lib/Target/R600/AMDGPUMCInstLower.cpp @@ -116,7 +116,7 @@ void AMDGPUAsmPrinter::EmitInstruction(const MachineInstr *MI) { MCInstLowering.lower(MI, TmpInst); EmitToStreamer(OutStreamer, TmpInst); - if (DisasmEnabled) { + if (MF->getSubtarget().dumpCode()) { // Disassemble instruction/operands to text. DisasmLines.resize(DisasmLines.size() + 1); std::string &DisasmLine = DisasmLines.back();