RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-19 19:12:56 +02:00
Code Issues Projects Releases Wiki Activity

[Support] unflake TempFileCollisions test

Browse Source 
Summary:
This test was added to verify that createUniqueEntity() does
not enter an infinite loop when all possible names are taken. However,
it also checked that all possible names are generated, which is flaky
(because the names are generated randomly). This change increases the
number of attempts we make to make flakes exceedingly
unlikely (3.88e-62).

Reviewers: fedor.sergeev, rsmith

Reviewed By: fedor.sergeev

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D56336

llvm-svn: 358914
This commit is contained in:
Bob Haarman 2019-04-22 19:46:25 +00:00
parent 0e2498cde5
commit 423505e721
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
unittests/Support/Path.cpp
View File

@ -700,10 +700,18 @@ TEST_F(FileSystemTest, TempFileCollisions) {
}
};
// We should be able to create exactly 16 temporary files.
for (int i = 0; i < 16; ++i)
EXPECT_TRUE(TryCreateTempFile());
EXPECT_FALSE(TryCreateTempFile());
// Our single-character template allows for 16 unique names. Check that
// calling TryCreateTempFile repeatedly results in 16 successes.
// Because the test depends on random numbers, it could theoretically fail.
// However, the probability of this happening is tiny: with 32 calls, each
// of which will retry up to 128 times, to not get a given digit we would
// have to fail at least 15 + 17 * 128 = 2191 attempts. The probability of
// 2191 attempts not producing a given hexadecimal digit is
// (1 - 1/16) ** 2191 or 3.88e-62.
int Successes = 0;
for (int i = 0; i < 32; ++i)
if (TryCreateTempFile()) ++Successes;
EXPECT_EQ(Successes, 16);
for (fs::TempFile &T : TempFiles)
cantFail(T.discard());