mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 18:54:02 +01:00
Fix an undefined behavior when storing an empty StringRef.
Summary: Passing a nullptr to memcpy is UB. Reviewers: ioeric Subscribers: llvm-commits, cfe-commits Differential Revision: https://reviews.llvm.org/D50966 llvm-svn: 340170
This commit is contained in:
parent
156400eb42
commit
4473c4ce87
@ -13,7 +13,8 @@ using namespace llvm;
|
||||
|
||||
StringRef StringSaver::save(StringRef S) {
|
||||
char *P = Alloc.Allocate<char>(S.size() + 1);
|
||||
memcpy(P, S.data(), S.size());
|
||||
if (!S.empty())
|
||||
memcpy(P, S.data(), S.size());
|
||||
P[S.size()] = '\0';
|
||||
return StringRef(P, S.size());
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user