RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-25 04:02:41 +01:00
Code Issues Projects Releases Wiki Activity

a byval argument is guaranteed to be valid to load.

Browse Source 
llvm-svn: 45877
This commit is contained in:
Chris Lattner 2008-01-11 19:34:32 +00:00
parent 129a0e4f7d
commit 44aaf42d14
1 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
lib/Transforms/IPO/ArgumentPromotion.cpp
View File

@ -193,7 +193,15 @@ static bool AllCalleesPassInValidPointerForArgument(Argument *Arg) {
bool ArgPromotion::isSafeToPromoteArgument(Argument *Arg, bool isByVal) const { bool ArgPromotion::isSafeToPromoteArgument(Argument *Arg, bool isByVal) const {
// We can only promote this argument if all of the uses are loads, or are GEP // We can only promote this argument if all of the uses are loads, or are GEP
// instructions (with constant indices) that are subsequently loaded. // instructions (with constant indices) that are subsequently loaded.
bool HasLoadInEntryBlock = false;
// We can also only promote the load if we can guarantee that it will happen.
// Promoting a load causes the load to be unconditionally executed in the
// caller, so we can't turn a conditional load into an unconditional load in
// general.
bool SafeToUnconditionallyLoad = false;
if (isByVal) // ByVal arguments are always safe to load from.
SafeToUnconditionallyLoad = true;
BasicBlock *EntryBlock = Arg->getParent()->begin(); BasicBlock *EntryBlock = Arg->getParent()->begin();
SmallVector<LoadInst*, 16> Loads; SmallVector<LoadInst*, 16> Loads;
std::vector<SmallVector<ConstantInt*, 8> > GEPIndices; std::vector<SmallVector<ConstantInt*, 8> > GEPIndices;
@ -202,7 +210,10 @@ bool ArgPromotion::isSafeToPromoteArgument(Argument *Arg, bool isByVal) const {
if (LoadInst *LI = dyn_cast<LoadInst>(*UI)) { if (LoadInst *LI = dyn_cast<LoadInst>(*UI)) {
if (LI->isVolatile()) return false; // Don't hack volatile loads if (LI->isVolatile()) return false; // Don't hack volatile loads
Loads.push_back(LI); Loads.push_back(LI);
HasLoadInEntryBlock |= LI->getParent() == EntryBlock;
// If this load occurs in the entry block, then the pointer is
// unconditionally loaded.
SafeToUnconditionallyLoad |= LI->getParent() == EntryBlock;
} else if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(*UI)) { } else if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(*UI)) {
if (GEP->use_empty()) { if (GEP->use_empty()) {
// Dead GEP's cause trouble later. Just remove them if we run into // Dead GEP's cause trouble later. Just remove them if we run into
@ -225,7 +236,10 @@ bool ArgPromotion::isSafeToPromoteArgument(Argument *Arg, bool isByVal) const {
if (LoadInst *LI = dyn_cast<LoadInst>(*UI)) { if (LoadInst *LI = dyn_cast<LoadInst>(*UI)) {
if (LI->isVolatile()) return false; // Don't hack volatile loads if (LI->isVolatile()) return false; // Don't hack volatile loads
Loads.push_back(LI); Loads.push_back(LI);
HasLoadInEntryBlock |= LI->getParent() == EntryBlock;
// If this load occurs in the entry block, then the pointer is
// unconditionally loaded.
SafeToUnconditionallyLoad |= LI->getParent() == EntryBlock;
} else { } else {
return false; return false;
} }
@ -257,7 +271,8 @@ bool ArgPromotion::isSafeToPromoteArgument(Argument *Arg, bool isByVal) const {
// of the pointer in the entry block of the function) or if we can prove that // of the pointer in the entry block of the function) or if we can prove that
// all pointers passed in are always to legal locations (for example, no null // all pointers passed in are always to legal locations (for example, no null
// pointers are passed in, no pointers to free'd memory, etc). // pointers are passed in, no pointers to free'd memory, etc).
if (!HasLoadInEntryBlock && !AllCalleesPassInValidPointerForArgument(Arg)) if (!SafeToUnconditionallyLoad &&
!AllCalleesPassInValidPointerForArgument(Arg))
return false; // Cannot prove that this is safe!! return false; // Cannot prove that this is safe!!
// Okay, now we know that the argument is only used by load instructions and // Okay, now we know that the argument is only used by load instructions and