RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 19:23:23 +01:00
Code Issues Projects Releases Wiki Activity

fix PR6112 - When globalopt (or any other pass) does RAUW(@G, %G),

Browse Source 
metadata references in non-function-local MDNodes should drop to 
null.

llvm-svn: 102519
This commit is contained in:
Chris Lattner 2010-04-28 20:16:12 +00:00
parent fb33f168e0
commit 4629370fa2
2 changed files with 34 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/VMCore/Metadata.cpp
View File

@ -178,6 +178,13 @@ void MDNode::destroy() {
free(this);
}
/// isFunctionLocalValue - Return true if this is a value that would require a
/// function-local MDNode.
static bool isFunctionLocalValue(Value *V) {
return isa<Instruction>(V) || isa<Argument>(V) || isa<BasicBlock>(V) ||
(isa<MDNode>(V) && cast<MDNode>(V)->isFunctionLocal());
}
MDNode *MDNode::getMDNode(LLVMContext &Context, Value *const *Vals,
unsigned NumVals, FunctionLocalness FL,
bool Insert) {
@ -188,8 +195,7 @@ MDNode *MDNode::getMDNode(LLVMContext &Context, Value *const *Vals,
for (unsigned i = 0; i != NumVals; ++i) {
Value *V = Vals[i];
if (!V) continue;
if (isa<Instruction>(V) || isa<Argument>(V) || isa<BasicBlock>(V) ||
(isa<MDNode>(V) && cast<MDNode>(V)->isFunctionLocal())) {
if (isFunctionLocalValue(V)) {
isFunctionLocal = true;
break;
}
@ -262,6 +268,13 @@ void MDNode::setIsNotUniqued() {
void MDNode::replaceOperand(MDNodeOperand *Op, Value *To) {
Value *From = *Op;
// If is possible that someone did GV->RAUW(inst), replacing a global variable
// with an instruction or some other function-local object. If this is a
// non-function-local MDNode, it can't point to a function-local object.
// Handle this case by implicitly dropping the MDNode reference to null.
if (!isFunctionLocal() && To && isFunctionLocalValue(To))
To = 0;
if (From == To)
return;

19
test/Transforms/GlobalOpt/metadata.ll Normal file
View File

@ -0,0 +1,19 @@
; RUN: opt -S -globalopt metadata.ll | FileCheck %s
; PR6112 - When globalopt does RAUW(@G, %G), the metadata reference should drop
; to null.
@G = internal global i8** null
define i32 @main(i32 %argc, i8** %argv) {
; CHECK: @main
; CHECK: %G = alloca
store i8** %argv, i8*** @G
ret i32 0
}
!named = !{!0}
; CHECK: !0 = metadata !{null}
!0 = metadata !{i8*** @G}