RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-18 10:32:48 +02:00
Code Issues Projects Releases Wiki Activity

[docs] Tweak update to Phabricator docs about setting repository for diffs uploaded via web

Browse Source 
Summary:
In D41919, I missed that there was a *second* step when uploading
diffs via web where the repository should be specified.

Reviewers: asb, probinson

Reviewed By: asb

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D41956

llvm-svn: 322375
This commit is contained in:
Ben Hamilton 2018-01-12 15:44:35 +00:00
parent d87d640668
commit 4929ea0ba7
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/Phabricator.rst
View File

@ -65,15 +65,16 @@ To upload a new patch:
* Click *Differential*.
* Click *+ Create Diff*.
* Paste the text diff or browse to the patch file. Click *Create Diff*.
* In the Repository field, enter the name of the project (LLVM, Clang,
etc.) to which the review should be sent.
* Leave this first Repository field blank. (We'll fill in the Repository
later, when sending the review.)
* Leave the drop down on *Create a new Revision...* and click *Continue*.
* Enter a descriptive title and summary. The title and summary are usually
in the form of a :ref:`commit message <commit messages>`.
* Add reviewers (see below for advice). (If you set the Repository field
correctly, llvm-commits or cfe-commits will be subscribed automatically;
otherwise, you will have to manually subscribe them.)
* Leave the Repository and Project fields blank.
* In the Repository field, enter the name of the project (LLVM, Clang,
etc.) to which the review should be sent.
* Click *Save*.
To submit an updated patch:
@ -83,7 +84,8 @@ To submit an updated patch:
* Paste the updated diff or browse to the updated patch file. Click *Create Diff*.
* Select the review you want to from the *Attach To* dropdown and click
*Continue*.
* Leave the Repository and Project fields blank.
* Leave the Repository field blank. (We previously filled out the Repository
for the review request.)
* Add comments about the changes in the new diff. Click *Save*.
Choosing reviewers: You typically pick one or two people as initial reviewers.