RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-22 02:33:06 +01:00
Code Issues Projects Releases Wiki Activity

[GlobalISel] Implement computeKnownBits for G_ASSERT_ZEXT

Browse Source 
It's the same as the ZEXT/TRUNC case, except SrcBitWidth is given by the
immediate operand.

Update KnownBitsTest.cpp and a MIR test for a concrete example.

Differential Revision: https://reviews.llvm.org/D95566
This commit is contained in:
Jessica Paquette 2021-01-27 14:01:38 -08:00
parent 0c8b3180a3
commit 4ae121a0d4
3 changed files with 121 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/CodeGen/GlobalISel/GISelKnownBits.cpp
View File

@ -403,13 +403,21 @@ void GISelKnownBits::computeKnownBitsImpl(Register R, KnownBits &Known,
case TargetOpcode::G_PTRTOINT:
// Fall through and handle them the same as zext/trunc.
LLVM_FALLTHROUGH;
case TargetOpcode::G_ASSERT_ZEXT:
case TargetOpcode::G_ZEXT:
case TargetOpcode::G_TRUNC: {
Register SrcReg = MI.getOperand(1).getReg();
LLT SrcTy = MRI.getType(SrcReg);
unsigned SrcBitWidth = SrcTy.isPointer()
? DL.getIndexSizeInBits(SrcTy.getAddressSpace())
: SrcTy.getSizeInBits();
unsigned SrcBitWidth;
// G_ASSERT_ZEXT stores the original bitwidth in the immediate operand.
if (Opcode == TargetOpcode::G_ASSERT_ZEXT)
SrcBitWidth = MI.getOperand(2).getImm();
else {
SrcBitWidth = SrcTy.isPointer()
? DL.getIndexSizeInBits(SrcTy.getAddressSpace())
: SrcTy.getSizeInBits();
}
assert(SrcBitWidth && "SrcBitWidth can't be zero");
Known = Known.zextOrTrunc(SrcBitWidth);
computeKnownBitsImpl(SrcReg, Known, DemandedElts, Depth + 1);

46
test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-and-trivial-mask.mir
View File

@ -221,3 +221,49 @@ body: |
$w0 = COPY %and(s32)
RET_ReallyLR implicit $w0
...
---
name: remove_and_assert_zext
legalized: true
tracksRegLiveness: true
body: |
bb.0:
liveins: $w0
; G_ASSERT_ZEXT communicates that only the bottom 8 bits of %x can be set.
; So, the G_AND can be removed.
; CHECK-LABEL: name: remove_and_assert_zext
; CHECK: liveins: $w0
; CHECK: %x:_(s32) = COPY $w0
; CHECK: %assert_zext:_(s32) = G_ASSERT_ZEXT %x, 8
; CHECK: $w0 = COPY %assert_zext(s32)
; CHECK: RET_ReallyLR implicit $w0
%x:_(s32) = COPY $w0
%assert_zext:_(s32) = G_ASSERT_ZEXT %x(s32), 8
%mask:_(s32) = G_CONSTANT i32 255
%and:_(s32) = G_AND %assert_zext(s32), %mask
$w0 = COPY %and(s32)
RET_ReallyLR implicit $w0
...
---
name: dont_remove_and_assert_zext_wrong_mask
legalized: true
tracksRegLiveness: true
body: |
bb.0:
liveins: $w0
; The mask here is for 8 bits, not 16.
; CHECK-LABEL: name: dont_remove_and_assert_zext
; CHECK: liveins: $w0
; CHECK: %x:_(s32) = COPY $w0
; CHECK: %assert_zext:_(s32) = G_ASSERT_ZEXT %x, 16
; CHECK: %mask:_(s32) = G_CONSTANT i32 255
; CHECK: %and:_(s32) = G_AND %assert_zext, %mask
; CHECK: $w0 = COPY %and(s32)
; CHECK: RET_ReallyLR implicit $w0
%x:_(s32) = COPY $w0
%assert_zext:_(s32) = G_ASSERT_ZEXT %x(s32), 16
%mask:_(s32) = G_CONSTANT i32 255
%and:_(s32) = G_AND %assert_zext(s32), %mask
$w0 = COPY %and(s32)
RET_ReallyLR implicit $w0

64
unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
View File

@ -913,3 +913,67 @@ TEST_F(AArch64GISelMITest, TestInvalidQueries) {
EXPECT_TRUE(BiggerSizeRes.One.isNullValue());
EXPECT_TRUE(BiggerSizeRes.Zero.isNullValue());
}
TEST_F(AArch64GISelMITest, TestKnownBitsAssertZext) {
StringRef MIRString = R"(
%copy:_(s64) = COPY $x0
%assert8:_(s64) = G_ASSERT_ZEXT %copy, 8
%copy_assert8:_(s64) = COPY %assert8
%assert1:_(s64) = G_ASSERT_ZEXT %copy, 1
%copy_assert1:_(s64) = COPY %assert1
%assert63:_(s64) = G_ASSERT_ZEXT %copy, 63
%copy_assert63:_(s64) = COPY %assert63
%assert3:_(s64) = G_ASSERT_ZEXT %copy, 3
%copy_assert3:_(s64) = COPY %assert3
)";
setUp(MIRString);
if (!TM)
return;
Register CopyAssert8 = Copies[Copies.size() - 4];
Register CopyAssert1 = Copies[Copies.size() - 3];
Register CopyAssert63 = Copies[Copies.size() - 2];
Register CopyAssert3 = Copies[Copies.size() - 1];
GISelKnownBits Info(*MF);
MachineInstr *Copy;
Register SrcReg;
KnownBits Res;
// Assert zero-extension from an 8-bit value.
Copy = MRI->getVRegDef(CopyAssert8);
SrcReg = Copy->getOperand(1).getReg();
Res = Info.getKnownBits(SrcReg);
EXPECT_EQ(64u, Res.getBitWidth());
EXPECT_EQ(0u, Res.One.getZExtValue());
EXPECT_EQ(0xFFFFFFFFFFFFFF00u, Res.Zero.getZExtValue());
// Assert zero-extension from a 1-bit value.
Copy = MRI->getVRegDef(CopyAssert1);
SrcReg = Copy->getOperand(1).getReg();
Res = Info.getKnownBits(SrcReg);
EXPECT_EQ(64u, Res.getBitWidth());
EXPECT_EQ(0u, Res.One.getZExtValue());
EXPECT_EQ(0xFFFFFFFFFFFFFFFE, Res.Zero.getZExtValue());
// Assert zero-extension from a 63-bit value.
Copy = MRI->getVRegDef(CopyAssert63);
SrcReg = Copy->getOperand(1).getReg();
Res = Info.getKnownBits(SrcReg);
EXPECT_EQ(64u, Res.getBitWidth());
EXPECT_EQ(0u, Res.One.getZExtValue());
EXPECT_EQ(0x8000000000000000u, Res.Zero.getZExtValue());
// Assert zero-extension from a 3-bit value.
Copy = MRI->getVRegDef(CopyAssert3);
SrcReg = Copy->getOperand(1).getReg();
Res = Info.getKnownBits(SrcReg);
EXPECT_EQ(64u, Res.getBitWidth());
EXPECT_EQ(0u, Res.One.getZExtValue());
EXPECT_EQ(0xFFFFFFFFFFFFFFF8u, Res.Zero.getZExtValue());
}