RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-01 05:01:59 +01:00
Code Issues Projects Releases Wiki Activity

[NFC] Mark Expected<T>::assertIsChecked() as const

Browse Source 
Some const methods of Expected<T> invoke assertIsChecked(),
so we should mark it as const too.

Differential Revision: https://reviews.llvm.org/D105292
This commit is contained in:
xndcn 2021-07-01 23:21:29 +08:00
parent 7f15962ed8
commit 4bda00e90e
2 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/llvm/Support/Error.h
View File

@ -703,7 +703,7 @@ private:
} }
#endif #endif
void assertIsChecked() { void assertIsChecked() const {
#if LLVM_ENABLE_ABI_BREAKING_CHECKS #if LLVM_ENABLE_ABI_BREAKING_CHECKS
if (LLVM_UNLIKELY(Unchecked)) if (LLVM_UNLIKELY(Unchecked))
fatalUncheckedExpected(); fatalUncheckedExpected();

18
unittests/Support/ErrorTest.cpp
View File

@ -556,7 +556,7 @@ TEST(Error, ExpectedWithReferenceType) {
TEST(Error, UncheckedExpectedInSuccessModeDestruction) { TEST(Error, UncheckedExpectedInSuccessModeDestruction) {
EXPECT_DEATH({ Expected<int> A = 7; }, EXPECT_DEATH({ Expected<int> A = 7; },
"Expected<T> must be checked before access or destruction.") "Expected<T> must be checked before access or destruction.")
<< "Unchecekd Expected<T> success value did not cause an abort()."; << "Unchecked Expected<T> success value did not cause an abort().";
} }
#endif #endif
@ -565,9 +565,13 @@ TEST(Error, UncheckedExpectedInSuccessModeDestruction) {
// Test runs in debug mode only. // Test runs in debug mode only.
#if LLVM_ENABLE_ABI_BREAKING_CHECKS #if LLVM_ENABLE_ABI_BREAKING_CHECKS
TEST(Error, UncheckedExpectedInSuccessModeAccess) { TEST(Error, UncheckedExpectedInSuccessModeAccess) {
EXPECT_DEATH({ Expected<int> A = 7; *A; }, EXPECT_DEATH(
{
const Expected<int> A = 7;
*A;
},
"Expected<T> must be checked before access or destruction.") "Expected<T> must be checked before access or destruction.")
<< "Unchecekd Expected<T> success value did not cause an abort()."; << "Unchecked Expected<T> success value did not cause an abort().";
} }
#endif #endif
@ -576,9 +580,13 @@ TEST(Error, UncheckedExpectedInSuccessModeAccess) {
// Test runs in debug mode only. // Test runs in debug mode only.
#if LLVM_ENABLE_ABI_BREAKING_CHECKS #if LLVM_ENABLE_ABI_BREAKING_CHECKS
TEST(Error, UncheckedExpectedInSuccessModeAssignment) { TEST(Error, UncheckedExpectedInSuccessModeAssignment) {
EXPECT_DEATH({ Expected<int> A = 7; A = 7; }, EXPECT_DEATH(
{
Expected<int> A = 7;
A = 7;
},
"Expected<T> must be checked before access or destruction.") "Expected<T> must be checked before access or destruction.")
<< "Unchecekd Expected<T> success value did not cause an abort()."; << "Unchecked Expected<T> success value did not cause an abort().";
} }
#endif #endif