RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00
Code Issues Projects Releases Wiki Activity

X86: remove temporary atomicrmw used during lowering.

Browse Source 
We construct a temporary "atomicrmw xchg" instruction when lowering atomic
stores for widths that aren't supported natively. This isn't on the top-level
worklist though, so it won't be removed automatically and we have to do it
ourselves once that itself has been lowered.

Thanks Saleem for pointing this out!

llvm-svn: 212948
This commit is contained in:
Tim Northover 2014-07-14 15:31:13 +00:00
parent cff61819ea
commit 4ef7afc394
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Target/X86/X86AtomicExpandPass.cpp
View File

@ -277,8 +277,11 @@ bool X86AtomicExpandPass::expandAtomicStore(StoreInst *SI) {
SI->getValueOperand(), Order);
// Now we have an appropriate swap instruction, lower it as usual.
if (shouldExpandAtomicRMW(AI))
return expandAtomicRMW(AI);
if (shouldExpandAtomicRMW(AI)) {
expandAtomicRMW(AI);
AI->eraseFromParent();
return true;
}
return AI;
}

1
test/CodeGen/X86/atomic128.ll
View File

@ -277,6 +277,7 @@ define void @atomic_store_seq_cst(i128* %p, i128 %in) {
; CHECK: lock
; CHECK: cmpxchg16b (%rdi)
; CHECK: jne [[LOOP]]
; CHECK-NOT: callq ___sync_lock_test_and_set_16
store atomic i128 %in, i128* %p seq_cst, align 16
ret void