RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-24 03:33:20 +01:00
Code Issues Projects Releases Wiki Activity

Rewrite getName{Start,End,Len} in terms of getName(), instead of vice-versa.

Browse Source 
llvm-svn: 77105
This commit is contained in:
Daniel Dunbar 2009-07-26 00:51:56 +00:00
parent b95150b65a
commit 518cd20f61
2 changed files with 14 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
include/llvm/Value.h
View File

@ -114,18 +114,22 @@ public:
/// getNameStart - Return a pointer to a null terminated string for this name.
/// Note that names can have null characters within the string as well as at
/// their end. This always returns a non-null pointer.
const char *getNameStart() const;
const char *getNameStart() const { return getName().begin(); }
/// getNameEnd - Return a pointer to the end of the name.
const char *getNameEnd() const { return getNameStart() + getNameLen(); }
const char *getNameEnd() const { return getName().end(); }
/// getNameLen - Return the length of the string, correctly handling nul
/// characters embedded into them.
unsigned getNameLen() const;
unsigned getNameLen() const { return getName().size(); }
/// getName()/getNameStr() - Return the name of the specified value,
/// *constructing a string* to hold it. Because these are guaranteed to
/// construct a string, they are very expensive and should be avoided.
StringRef getName() const { return StringRef(getNameStart(), getNameLen()); }
/// getName() - Return a constant reference to the value's name. This is cheap
/// and guaranteed to return the same reference as long as the value is not
/// modified.
StringRef getName() const;
/// getNameStr() - Return the name of the specified value, *constructing a
/// string* to hold it. This is guaranteed to construct a string and is very
/// expensive, clients should use getName() unless necessary.
std::string getNameStr() const;
/// setName() - Change the name of the value, choosing a new unique name if

16
lib/VMCore/Value.cpp
View File

@ -151,21 +151,11 @@ static bool getSymTab(Value *V, ValueSymbolTable *&ST) {
return false;
}
/// getNameStart - Return a pointer to a null terminated string for this name.
/// Note that names can have null characters within the string as well as at
/// their end. This always returns a non-null pointer.
const char *Value::getNameStart() const {
if (Name == 0) return "";
return Name->getKeyData();
StringRef Value::getName() const {
if (!Name) return StringRef();
return Name->getKey();
}
/// getNameLen - Return the length of the string, correctly handling nul
/// characters embedded into them.
unsigned Value::getNameLen() const {
return Name ? Name->getKeyLength() : 0;
}
std::string Value::getNameStr() const {
return getName().str();
}