RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-01 05:01:59 +01:00
Code Issues Projects Releases Wiki Activity

[XRay] Remove array for Metadata Record Types

Browse Source 
This simplifies the implementation of the metadata lookup by using
scoped enums, rather than using enum classes. This way we can get the
number-name mapping without having to resort to comments.

Follow-up to D51289.

llvm-svn: 341205
This commit is contained in:
Dean Michael Berris 2018-08-31 11:41:08 +00:00
parent c68b38b9f3
commit 53982eabea
1 changed files with 28 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
lib/XRay/FDRRecordProducer.cpp
View File

@ -14,66 +14,54 @@ namespace xray {
namespace {
// Keep this in sync with the values written in the XRay FDR mode runtime in
// compiler-rt.
enum class MetadataRecordKinds : uint8_t {
NewBuffer,
EndOfBuffer,
NewCPUId,
TSCWrap,
WalltimeMarker,
CustomEventMarker,
CallArgument,
BufferExtents,
TypedEventMarker,
Pid,
// This is an end marker, used to identify the upper bound for this enum.
EnumEndMarker,
};
Expected<std::unique_ptr<Record>>
metadataRecordType(const XRayFileHeader &Header, uint8_t T) {
// Keep this in sync with the values written in the XRay FDR mode runtime in
// compiler-rt.
enum MetadataRecordKinds : uint8_t {
NewBufferKind,
EndOfBufferKind,
NewCPUIdKind,
TSCWrapKind,
WalltimeMarkerKind,
CustomEventMarkerKind,
CallArgumentKind,
BufferExtentsKind,
TypedEventMarkerKind,
PidKind,
// This is an end marker, used to identify the upper bound for this enum.
EnumEndMarker,
};
if (T >= static_cast<uint8_t>(MetadataRecordKinds::EnumEndMarker))
return createStringError(std::make_error_code(std::errc::invalid_argument),
"Invalid metadata record type: %d", T);
static constexpr MetadataRecordKinds Mapping[] = {
MetadataRecordKinds::NewBuffer,
MetadataRecordKinds::EndOfBuffer,
MetadataRecordKinds::NewCPUId,
MetadataRecordKinds::TSCWrap,
MetadataRecordKinds::WalltimeMarker,
MetadataRecordKinds::CustomEventMarker,
MetadataRecordKinds::CallArgument,
MetadataRecordKinds::BufferExtents,
MetadataRecordKinds::TypedEventMarker,
MetadataRecordKinds::Pid,
};
switch (Mapping[T]) {
case MetadataRecordKinds::NewBuffer:
switch (T) {
case MetadataRecordKinds::NewBufferKind:
return make_unique<NewBufferRecord>();
case MetadataRecordKinds::EndOfBuffer:
case MetadataRecordKinds::EndOfBufferKind:
if (Header.Version >= 2)
return createStringError(
std::make_error_code(std::errc::executable_format_error),
"End of buffer records are no longer supported starting version "
"2 of the log.");
return make_unique<EndBufferRecord>();
case MetadataRecordKinds::NewCPUId:
case MetadataRecordKinds::NewCPUIdKind:
return make_unique<NewCPUIDRecord>();
case MetadataRecordKinds::TSCWrap:
case MetadataRecordKinds::TSCWrapKind:
return make_unique<TSCWrapRecord>();
case MetadataRecordKinds::WalltimeMarker:
case MetadataRecordKinds::WalltimeMarkerKind:
return make_unique<WallclockRecord>();
case MetadataRecordKinds::CustomEventMarker:
case MetadataRecordKinds::CustomEventMarkerKind:
return make_unique<CustomEventRecord>();
case MetadataRecordKinds::CallArgument:
case MetadataRecordKinds::CallArgumentKind:
return make_unique<CallArgRecord>();
case MetadataRecordKinds::BufferExtents:
case MetadataRecordKinds::BufferExtentsKind:
return make_unique<BufferExtents>();
case MetadataRecordKinds::TypedEventMarker:
case MetadataRecordKinds::TypedEventMarkerKind:
return createStringError(std::make_error_code(std::errc::invalid_argument),
"Encountered an unsupported TypedEventMarker.");
case MetadataRecordKinds::Pid:
case MetadataRecordKinds::PidKind:
return make_unique<PIDRecord>();
case MetadataRecordKinds::EnumEndMarker:
llvm_unreachable("Invalid MetadataRecordKind");