mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 18:54:02 +01:00
Revert r348243 "[llvm-mc] - Do not crash when referencing undefined debug sections."
It broke msan and asan bots it seems: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/26794/steps/check-llvm%20msan/logs/stdio http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/20993/steps/ninja%20check%201/logs/stdio llvm-svn: 348248
This commit is contained in:
parent
08d0473ebf
commit
53bdc3426f
@ -669,20 +669,6 @@ void ELFWriter::computeSymbolTable(
|
||||
} else {
|
||||
const MCSectionELF &Section =
|
||||
static_cast<const MCSectionELF &>(Symbol.getSection());
|
||||
|
||||
// We may end up with a situation when section symbol is technically
|
||||
// defined, but should not be. That happens because we explicitly
|
||||
// pre-create few .debug_* sections to have accessors.
|
||||
// And if these sections were not really defined in the code, but were
|
||||
// referenced, we simply error out.
|
||||
if (!Section.isRegistered()) {
|
||||
assert(static_cast<const MCSymbolELF &>(Symbol).getType() ==
|
||||
ELF::STT_SECTION);
|
||||
Ctx.reportError(SMLoc(),
|
||||
"Undefined section reference: " + Symbol.getName());
|
||||
continue;
|
||||
}
|
||||
|
||||
if (Mode == NonDwoOnly && isDwoSection(Section))
|
||||
continue;
|
||||
MSD.SectionIndex = SectionIndexMap.lookup(&Section);
|
||||
|
@ -1,5 +0,0 @@
|
||||
// RUN: not llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu %s -o %t 2>&1 | FileCheck %s
|
||||
// CHECK: error: Undefined section reference: .debug_pubnames
|
||||
|
||||
.section .foo,"",@progbits
|
||||
.long .debug_pubnames
|
Loading…
Reference in New Issue
Block a user