mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 19:12:56 +02:00
Revert "[CFI] Remove LinkerSubsectionsViaSymbols."
This reverts commit r304582: breaks cfi-devirt :: anon-namespace.cpp on Darwin. llvm-svn: 304626
This commit is contained in:
parent
4633c07b46
commit
55b44f072f
@ -235,6 +235,7 @@ class LowerTypeTestsModule {
|
||||
ModuleSummaryIndex *ExportSummary;
|
||||
const ModuleSummaryIndex *ImportSummary;
|
||||
|
||||
bool LinkerSubsectionsViaSymbols;
|
||||
Triple::ArchType Arch;
|
||||
Triple::OSType OS;
|
||||
Triple::ObjectFormatType ObjectFormat;
|
||||
@ -474,9 +475,13 @@ void LowerTypeTestsModule::allocateByteArrays() {
|
||||
// Create an alias instead of RAUW'ing the gep directly. On x86 this ensures
|
||||
// that the pc-relative displacement is folded into the lea instead of the
|
||||
// test instruction getting another displacement.
|
||||
GlobalAlias *Alias = GlobalAlias::create(
|
||||
Int8Ty, 0, GlobalValue::PrivateLinkage, "bits", GEP, &M);
|
||||
BAI->ByteArray->replaceAllUsesWith(Alias);
|
||||
if (LinkerSubsectionsViaSymbols) {
|
||||
BAI->ByteArray->replaceAllUsesWith(GEP);
|
||||
} else {
|
||||
GlobalAlias *Alias = GlobalAlias::create(
|
||||
Int8Ty, 0, GlobalValue::PrivateLinkage, "bits", GEP, &M);
|
||||
BAI->ByteArray->replaceAllUsesWith(Alias);
|
||||
}
|
||||
BAI->ByteArray->eraseFromParent();
|
||||
}
|
||||
|
||||
@ -497,7 +502,7 @@ Value *LowerTypeTestsModule::createBitSetTest(IRBuilder<> &B,
|
||||
return createMaskedBitTest(B, TIL.InlineBits, BitOffset);
|
||||
} else {
|
||||
Constant *ByteArray = TIL.TheByteArray;
|
||||
if (AvoidReuse && !ImportSummary) {
|
||||
if (!LinkerSubsectionsViaSymbols && AvoidReuse && !ImportSummary) {
|
||||
// Each use of the byte array uses a different alias. This makes the
|
||||
// backend less likely to reuse previously computed byte array addresses,
|
||||
// improving the security of the CFI mechanism based on this pass.
|
||||
@ -675,13 +680,17 @@ void LowerTypeTestsModule::buildBitSetsFromGlobalVariables(
|
||||
ConstantInt::get(Int32Ty, I * 2)};
|
||||
Constant *CombinedGlobalElemPtr = ConstantExpr::getGetElementPtr(
|
||||
NewInit->getType(), CombinedGlobal, CombinedGlobalIdxs);
|
||||
assert(GV->getType()->getAddressSpace() == 0);
|
||||
GlobalAlias *GAlias =
|
||||
GlobalAlias::create(NewTy->getElementType(I * 2), 0, GV->getLinkage(),
|
||||
"", CombinedGlobalElemPtr, &M);
|
||||
GAlias->setVisibility(GV->getVisibility());
|
||||
GAlias->takeName(GV);
|
||||
GV->replaceAllUsesWith(GAlias);
|
||||
if (LinkerSubsectionsViaSymbols) {
|
||||
GV->replaceAllUsesWith(CombinedGlobalElemPtr);
|
||||
} else {
|
||||
assert(GV->getType()->getAddressSpace() == 0);
|
||||
GlobalAlias *GAlias = GlobalAlias::create(NewTy->getElementType(I * 2), 0,
|
||||
GV->getLinkage(), "",
|
||||
CombinedGlobalElemPtr, &M);
|
||||
GAlias->setVisibility(GV->getVisibility());
|
||||
GAlias->takeName(GV);
|
||||
GV->replaceAllUsesWith(GAlias);
|
||||
}
|
||||
GV->eraseFromParent();
|
||||
}
|
||||
}
|
||||
@ -1157,7 +1166,8 @@ void LowerTypeTestsModule::buildBitSetsFromFunctionsNative(
|
||||
ArrayRef<Constant *>{ConstantInt::get(IntPtrTy, 0),
|
||||
ConstantInt::get(IntPtrTy, I)}),
|
||||
F->getType());
|
||||
if (F->isDeclarationForLinker()) {
|
||||
if (LinkerSubsectionsViaSymbols || F->isDeclarationForLinker()) {
|
||||
|
||||
if (F->isWeakForLinker())
|
||||
replaceWeakDeclarationWithJumpTablePtr(F, CombinedGlobalElemPtr);
|
||||
else
|
||||
@ -1292,6 +1302,7 @@ LowerTypeTestsModule::LowerTypeTestsModule(
|
||||
: M(M), ExportSummary(ExportSummary), ImportSummary(ImportSummary) {
|
||||
assert(!(ExportSummary && ImportSummary));
|
||||
Triple TargetTriple(M.getTargetTriple());
|
||||
LinkerSubsectionsViaSymbols = TargetTriple.isMacOSX();
|
||||
Arch = TargetTriple.getArch();
|
||||
OS = TargetTriple.getOS();
|
||||
ObjectFormat = TargetTriple.getObjectFormat();
|
||||
|
@ -1,5 +1,5 @@
|
||||
; RUN: opt -S -lowertypetests < %s | FileCheck %s
|
||||
; RUN: opt -S -lowertypetests -mtriple=x86_64-apple-macosx10.8.0 < %s | FileCheck %s
|
||||
; RUN: opt -S -lowertypetests -mtriple=x86_64-apple-macosx10.8.0 < %s | FileCheck -check-prefix=CHECK-DARWIN %s
|
||||
; RUN: opt -S -O3 < %s | FileCheck -check-prefix=CHECK-NODISCARD %s
|
||||
|
||||
target datalayout = "e-p:32:32"
|
||||
@ -39,6 +39,20 @@ target datalayout = "e-p:32:32"
|
||||
; CHECK: @c = protected alias i32, getelementptr inbounds ({ i32, [0 x i8], [63 x i32], [4 x i8], i32, [0 x i8], [2 x i32] }, { i32, [0 x i8], [63 x i32], [4 x i8], i32, [0 x i8], [2 x i32] }* [[G]], i32 0, i32 4)
|
||||
; CHECK: @d = alias [2 x i32], getelementptr inbounds ({ i32, [0 x i8], [63 x i32], [4 x i8], i32, [0 x i8], [2 x i32] }, { i32, [0 x i8], [63 x i32], [4 x i8], i32, [0 x i8], [2 x i32] }* [[G]], i32 0, i32 6)
|
||||
|
||||
; CHECK-DARWIN: @aptr = constant i32* getelementptr inbounds ({ i32, [0 x i8], [63 x i32], [4 x i8], i32, [0 x i8], [2 x i32] }, { i32, [0 x i8], [63 x i32], [4 x i8], i32, [0 x i8], [2 x i32] }* [[G:@[^ ]*]], i32 0, i32 0)
|
||||
@aptr = constant i32* @a
|
||||
|
||||
; CHECK-DARWIN: @bptr = constant [63 x i32]* getelementptr inbounds ({ i32, [0 x i8], [63 x i32], [4 x i8], i32, [0 x i8], [2 x i32] }, { i32, [0 x i8], [63 x i32], [4 x i8], i32, [0 x i8], [2 x i32] }* [[G]], i32 0, i32 2)
|
||||
@bptr = constant [63 x i32]* @b
|
||||
|
||||
; CHECK-DARWIN: @cptr = constant i32* getelementptr inbounds ({ i32, [0 x i8], [63 x i32], [4 x i8], i32, [0 x i8], [2 x i32] }, { i32, [0 x i8], [63 x i32], [4 x i8], i32, [0 x i8], [2 x i32] }* [[G]], i32 0, i32 4)
|
||||
@cptr = constant i32* @c
|
||||
|
||||
; CHECK-DARWIN: @dptr = constant [2 x i32]* getelementptr inbounds ({ i32, [0 x i8], [63 x i32], [4 x i8], i32, [0 x i8], [2 x i32] }, { i32, [0 x i8], [63 x i32], [4 x i8], i32, [0 x i8], [2 x i32] }* [[G]], i32 0, i32 6)
|
||||
@dptr = constant [2 x i32]* @d
|
||||
|
||||
; CHECK-DARWIN: [[G]] = private constant
|
||||
|
||||
; CHECK: @bits{{[0-9]*}} = private alias i8, getelementptr inbounds ([68 x i8], [68 x i8]* [[BA]], i32 0, i32 0)
|
||||
; CHECK: @bits.{{[0-9]*}} = private alias i8, getelementptr inbounds ([68 x i8], [68 x i8]* [[BA]], i32 0, i32 0)
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user