From 5687a21fc1e5b14f7764bc8c2eb3a7fee6d8b3ec Mon Sep 17 00:00:00 2001 From: David Tenty Date: Wed, 11 Dec 2019 17:21:54 -0500 Subject: [PATCH] Don't call export_symbols.py with duplicate libs Summary: export_symbols.py discards duplicate symbols, assuming they have public definitions, so if we end up calling it with duplicate libraries we will end up with an inaccurate export list. Reviewers: jasonliu, stevewan, john.brawn Reviewed By: john.brawn Subscribers: mgorny, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D70918 --- cmake/modules/AddLLVM.cmake | 1 + 1 file changed, 1 insertion(+) diff --git a/cmake/modules/AddLLVM.cmake b/cmake/modules/AddLLVM.cmake index 518ea608d23..34f532c9e45 100644 --- a/cmake/modules/AddLLVM.cmake +++ b/cmake/modules/AddLLVM.cmake @@ -873,6 +873,7 @@ function(export_executable_symbols target) set(new_libs ${newer_libs}) set(newer_libs "") endwhile() + list(REMOVE_DUPLICATES static_libs) if (MSVC) set(mangling microsoft) else()