RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-21 03:53:04 +02:00
Code Issues Projects Releases Wiki Activity

GlobalISel: rework getOrCreateVReg to avoid double lookup. NFC.

Browse Source 
Thanks to Quentin for suggesting the refactoring.

llvm-svn: 293087
This commit is contained in:
Tim Northover 2017-01-25 20:58:22 +00:00
parent 661dbed574
commit 5692382183
1 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
lib/CodeGen/GlobalISel/IRTranslator.cpp
View File

@ -60,30 +60,30 @@ void IRTranslator::getAnalysisUsage(AnalysisUsage &AU) const {
unsigned IRTranslator::getOrCreateVReg(const Value &Val) {
unsigned &ValReg = ValToVReg[&Val];
// Check if this is the first time we see Val.
if (!ValReg) {
// Fill ValRegsSequence with the sequence of registers
// we need to concat together to produce the value.
assert(Val.getType()->isSized() &&
"Don't know how to create an empty vreg");
unsigned VReg = MRI->createGenericVirtualRegister(LLT{*Val.getType(), *DL});
ValReg = VReg;
if (auto CV = dyn_cast<Constant>(&Val)) {
bool Success = translate(*CV, VReg);
if (!Success) {
if (!TPC->isGlobalISelAbortEnabled()) {
MF->getProperties().set(
MachineFunctionProperties::Property::FailedISel);
return VReg;
}
reportTranslationError(Val, "unable to translate constant");
if (ValReg)
return ValReg;
// Fill ValRegsSequence with the sequence of registers
// we need to concat together to produce the value.
assert(Val.getType()->isSized() &&
"Don't know how to create an empty vreg");
unsigned VReg = MRI->createGenericVirtualRegister(LLT{*Val.getType(), *DL});
ValReg = VReg;
if (auto CV = dyn_cast<Constant>(&Val)) {
bool Success = translate(*CV, VReg);
if (!Success) {
if (!TPC->isGlobalISelAbortEnabled()) {
MF->getProperties().set(
MachineFunctionProperties::Property::FailedISel);
return VReg;
}
reportTranslationError(Val, "unable to translate constant");
}
}
// Look Val up again in case the reference has been invalidated since.
return ValToVReg[&Val];
return VReg;
}
int IRTranslator::getOrCreateFrameIndex(const AllocaInst &AI) {