[PM] Remove a pointless optimization.

There is no need to do this within an analysis. That method shouldn't
even be reached if this predicate holds as the actual useful
optimization is in the analysis manager itself.

llvm-svn: 290614

lib/Analysis/AliasAnalysis.cpp

@@ -72,9 +72,6 @@ AAResults::~AAResults() {
 
 bool AAResults::invalidate(Function &F, const PreservedAnalyses &PA,
                            FunctionAnalysisManager::Invalidator &Inv) {
-  if (PA.areAllPreserved())
-    return false; // Nothing to do, everything is still valid.
-
   // Check if the AA manager itself has been invalidated.
   auto PAC = PA.getChecker<AAManager>();
   if (!PAC.preserved() && !PAC.preservedSet<AllAnalysesOn<Function>>())

lib/Analysis/BasicAliasAnalysis.cpp

@@ -65,9 +65,6 @@ static const unsigned MaxLookupSearchDepth = 6;
 
 bool BasicAAResult::invalidate(Function &F, const PreservedAnalyses &PA,
                                FunctionAnalysisManager::Invalidator &Inv) {
-  if (PA.areAllPreserved())
-    return false; // Nothing to do, everything is still valid.
-
   // We don't care if this analysis itself is preserved, it has no state. But
   // we need to check that the analyses it depends on have been. Note that we
   // may be created without handles to some analyses and in that case don't