RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-18 18:42:46 +02:00
Code Issues Projects Releases Wiki Activity

[AttributeFuncs] Consider align in typeIncompatible

Browse Source 
Alignment attributes need to be dropped for non-pointer values.
This also introduces a check into the verifier to ensure you don't use
`align` on anything but a pointer. Test needed to be adjusted
accordingly.

Reviewed By: fhahn

Differential Revision: https://reviews.llvm.org/D87304
This commit is contained in:
Johannes Doerfert 2020-09-08 10:10:36 -05:00
parent 83ae2d53d6
commit 5dc5457fbf
8 changed files with 27 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/IR/Attributes.cpp
View File

@ -1848,6 +1848,7 @@ AttrBuilder AttributeFuncs::typeIncompatible(Type *Ty) {
.addAttribute(Attribute::NoAlias)
.addAttribute(Attribute::NoCapture)
.addAttribute(Attribute::NonNull)
.addAlignmentAttr(1) // the int here is ignored
.addDereferenceableAttr(1) // the int here is ignored
.addDereferenceableOrNullAttr(1) // the int here is ignored
.addAttribute(Attribute::ReadNone)

4
test/Bitcode/attributes-3.3.ll
View File

@ -101,8 +101,8 @@ define void @f16() sspreq
ret void;
}
define void @f17(i8 align 4 %0)
; CHECK: define void @f17(i8 align 4 %0)
define void @f17(i8* align 4 %0)
; CHECK: define void @f17(i8* align 4 %0)
{
ret void;
}

BIN
test/Bitcode/attributes-3.3.ll.bc
View File

Binary file not shown.

4
test/Bitcode/attributes.ll
View File

@ -98,8 +98,8 @@ define void @f16() sspreq
ret void;
}
define void @f17(i8 align 4 %0)
; CHECK: define void @f17(i8 align 4 %0)
define void @f17(i8* align 4 %0)
; CHECK: define void @f17(i8* align 4 %0)
{
ret void;
}

7
test/Transforms/DeadArgElim/returned.ll
View File

@ -43,6 +43,12 @@ define internal %Ty* @test5(%Ty* %this) {
ret %Ty* %this
}
; Drop all these attributes
; CHECK-LABEL: define internal void @test6
define internal align 8 dereferenceable_or_null(2) noalias i8* @test6() {
ret i8* null
}
define %Ty* @caller(%Ty* %this) {
%1 = call %Ty* @test1(%Ty* %this)
%2 = call %Ty* @test2(%Ty* %this)
@ -51,5 +57,6 @@ define %Ty* @caller(%Ty* %this) {
; ...instead, drop 'returned' form the call site
; CHECK: call void @test5(%Ty* %this)
%5 = call %Ty* @test5(%Ty* returned %this)
%6 = call i8* @test6()
ret %Ty* %this
}

2
test/Transforms/LoopSimplify/unreachable-loop-pred.ll
View File

@ -22,7 +22,7 @@ foo:
; When loopsimplify generates dedicated exit block for blocks that are landing
; pads (i.e. innerLoopExit in this test), we should not get confused with the
; unreachable pred (unreachableB) to innerLoopExit.
define align 8 void @baz(i32 %trip) personality i32* ()* @wobble {
define void @baz(i32 %trip) personality i32* ()* @wobble {
entry:
br label %outerHeader

13
test/Verifier/align.ll Normal file
View File

@ -0,0 +1,13 @@
; RUN: not llvm-as < %s -o /dev/null 2>&1 | FileCheck %s
; CHECK: Wrong types for attribute: inalloca nest noalias nocapture nonnull readnone readonly byref(i32) byval(i32) preallocated(i32) sret(i32) align 1 dereferenceable(1) dereferenceable_or_null(1)
; CHECK-NEXT: @align_non_pointer1
define void @align_non_pointer1(i32 align 4 %a) {
ret void
}
; CHECK: Wrong types for attribute: inalloca nest noalias nocapture nonnull readnone readonly signext zeroext byref(void) byval(void) preallocated(void) sret(void) align 1 dereferenceable(1) dereferenceable_or_null(1)
; CHECK-NEXT: @align_non_pointer2
define align 4 void @align_non_pointer2(i32 %a) {
ret void
}

2
test/Verifier/byref.ll
View File

@ -56,7 +56,7 @@ define void @byref_nest(i32* byref(i32) nest) {
ret void
}
; CHECK: Wrong types for attribute: inalloca nest noalias nocapture nonnull readnone readonly sret byref(i32) byval(i32) preallocated(i32) dereferenceable(1) dereferenceable_or_null(1)
; CHECK: Wrong types for attribute: inalloca nest noalias nocapture nonnull readnone readonly sret byref(i32) byval(i32) preallocated(i32) align 1 dereferenceable(1) dereferenceable_or_null(1)
; CHECK-NEXT: void (i32)* @byref_non_pointer
define void @byref_non_pointer(i32 byref(i32)) {
ret void