RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 12:41:49 +01:00
Code Issues Projects Releases Wiki Activity

[Support] Replace function with function_ref in writeFileAtomically. NFC

Browse Source 
Summary:
The latter is slightly more efficient and communicates the intent of the
API: writeFileAtomically does not own or copy the callback, it merely
calls it at some point.

Reviewers: jkorous

Reviewed By: jkorous

Subscribers: hiraditya, dexonsmith, jfb, llvm-commits, cfe-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D67584

llvm-svn: 372201
This commit is contained in:
Ilya Biryukov 2019-09-18 08:31:28 +00:00
parent a5385636e7
commit 5e10e7bc8c
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
include/llvm/Support/FileUtilities.h
View File

@ -14,6 +14,7 @@
#ifndef LLVM_SUPPORT_FILEUTILITIES_H #ifndef LLVM_SUPPORT_FILEUTILITIES_H
#define LLVM_SUPPORT_FILEUTILITIES_H #define LLVM_SUPPORT_FILEUTILITIES_H
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/StringRef.h" #include "llvm/ADT/StringRef.h"
#include "llvm/Support/Errc.h" #include "llvm/Support/Errc.h"
#include "llvm/Support/ErrorHandling.h" #include "llvm/Support/ErrorHandling.h"
@ -107,9 +108,9 @@ namespace llvm {
llvm::Error writeFileAtomically(StringRef TempPathModel, StringRef FinalPath, llvm::Error writeFileAtomically(StringRef TempPathModel, StringRef FinalPath,
StringRef Buffer); StringRef Buffer);
llvm::Error llvm::Error writeFileAtomically(
writeFileAtomically(StringRef TempPathModel, StringRef FinalPath, StringRef TempPathModel, StringRef FinalPath,
std::function<llvm::Error(llvm::raw_ostream &)> Writer); llvm::function_ref<llvm::Error(llvm::raw_ostream &)> Writer);
} // End llvm namespace } // End llvm namespace
#endif #endif

2
lib/Support/FileUtilities.cpp
View File

@ -296,7 +296,7 @@ llvm::Error llvm::writeFileAtomically(StringRef TempPathModel,
llvm::Error llvm::writeFileAtomically( llvm::Error llvm::writeFileAtomically(
StringRef TempPathModel, StringRef FinalPath, StringRef TempPathModel, StringRef FinalPath,
std::function<llvm::Error(llvm::raw_ostream &)> Writer) { llvm::function_ref<llvm::Error(llvm::raw_ostream &)> Writer) {
SmallString<128> GeneratedUniqPath; SmallString<128> GeneratedUniqPath;
int TempFD; int TempFD;
if (sys::fs::createUniqueFile(TempPathModel.str(), TempFD, if (sys::fs::createUniqueFile(TempPathModel.str(), TempFD,