From 5e515eb4275bb561aa77cc712e16f0612449f4b7 Mon Sep 17 00:00:00 2001 From: Aaron Puchert Date: Sat, 5 Jun 2021 15:04:18 +0200 Subject: [PATCH] Make TableGenGlobalISel an object library That's how it was originally intended but that wasn't possible because we still needed to support older CMake versions. The problem here is that the sources in TableGenGlobalISel are meant to be linked into both llvm-tblgen and TableGenTests (a unit test), but not be part of LLVM proper. So they shouldn't be an ordinary LLVM component. Because they are used in llvm-tblgen, they can't draw in the LLVM dylib dependency, but then we'd have to do the same thing in TableGenTests to make sure we don't link both a static Support library and another copy through the LLVM dylib. With an object library we're just reusing the object files and don't have to care about dependencies at all. Differential Revision: https://reviews.llvm.org/D74588 --- unittests/TableGen/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unittests/TableGen/CMakeLists.txt b/unittests/TableGen/CMakeLists.txt index 178018ba896..15f60800aa9 100644 --- a/unittests/TableGen/CMakeLists.txt +++ b/unittests/TableGen/CMakeLists.txt @@ -9,7 +9,7 @@ tablegen(LLVM AutomataTables.inc -gen-searchable-tables) tablegen(LLVM AutomataAutomata.inc -gen-automata) add_public_tablegen_target(AutomataTestTableGen) -add_llvm_unittest(TableGenTests +add_llvm_unittest(TableGenTests DISABLE_LLVM_LINK_LLVM_DYLIB CodeExpanderTest.cpp AutomataTest.cpp )