diff --git a/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/lib/CodeGen/SelectionDAG/SelectionDAG.cpp index 95dc5ab657d..1472490cca8 100644 --- a/lib/CodeGen/SelectionDAG/SelectionDAG.cpp +++ b/lib/CodeGen/SelectionDAG/SelectionDAG.cpp @@ -1554,7 +1554,12 @@ SDValue SelectionDAG::FoldSetCC(EVT VT, SDValue N1, case ISD::SETFALSE: case ISD::SETFALSE2: return getConstant(0, VT); case ISD::SETTRUE: - case ISD::SETTRUE2: return getConstant(1, VT); + case ISD::SETTRUE2: { + const TargetLowering *TLI = TM.getTargetLowering(); + TargetLowering::BooleanContent Cnt = TLI->getBooleanContents(VT.isVector()); + return getConstant( + Cnt == TargetLowering::ZeroOrNegativeOneBooleanContent ? -1ULL : 1, VT); + } case ISD::SETOEQ: case ISD::SETOGT: diff --git a/lib/CodeGen/SelectionDAG/TargetLowering.cpp b/lib/CodeGen/SelectionDAG/TargetLowering.cpp index df672214365..f2199d7730d 100644 --- a/lib/CodeGen/SelectionDAG/TargetLowering.cpp +++ b/lib/CodeGen/SelectionDAG/TargetLowering.cpp @@ -1080,7 +1080,11 @@ TargetLowering::SimplifySetCC(EVT VT, SDValue N0, SDValue N1, case ISD::SETFALSE: case ISD::SETFALSE2: return DAG.getConstant(0, VT); case ISD::SETTRUE: - case ISD::SETTRUE2: return DAG.getConstant(1, VT); + case ISD::SETTRUE2: { + TargetLowering::BooleanContent Cnt = getBooleanContents(VT.isVector()); + return DAG.getConstant( + Cnt == TargetLowering::ZeroOrNegativeOneBooleanContent ? -1ULL : 1, VT); + } } // Ensure that the constant occurs on the RHS, and fold constant diff --git a/test/CodeGen/X86/vec_setcc.ll b/test/CodeGen/X86/vec_setcc.ll index 6ef23c9bdd0..fc8a56de791 100644 --- a/test/CodeGen/X86/vec_setcc.ll +++ b/test/CodeGen/X86/vec_setcc.ll @@ -124,3 +124,64 @@ define <4 x i32> @v4i32_icmp_ule(<4 x i32> %a, <4 x i32> %b) nounwind readnone s ; AVX: pcmpeqd %xmm1, %xmm0, %xmm0 } +; At one point we were incorrectly constant-folding a setcc to 0x1 instead of +; 0xff, leading to a constpool load. The instruction doesn't matter here, but it +; should set all bits to 1. +define <16 x i8> @test_setcc_constfold_vi8(<16 x i8> %l, <16 x i8> %r) { + %test1 = icmp eq <16 x i8> %l, %r + %mask1 = sext <16 x i1> %test1 to <16 x i8> + + %test2 = icmp ne <16 x i8> %l, %r + %mask2 = sext <16 x i1> %test2 to <16 x i8> + + %res = or <16 x i8> %mask1, %mask2 + ret <16 x i8> %res +; SSE2-LABEL: test_setcc_constfold_vi8: +; SSE2: pcmpeqd %xmm0, %xmm0 + +; SSE41-LABEL: test_setcc_constfold_vi8: +; SSE41: pcmpeqd %xmm0, %xmm0 + +; AVX-LABEL: test_setcc_constfold_vi8: +; AVX: vpcmpeqd %xmm0, %xmm0, %xmm0 +} + +; Make sure sensible results come from doing extension afterwards +define <16 x i8> @test_setcc_constfold_vi1(<16 x i8> %l, <16 x i8> %r) { + %test1 = icmp eq <16 x i8> %l, %r + %test2 = icmp ne <16 x i8> %l, %r + + %res = or <16 x i1> %test1, %test2 + %mask = sext <16 x i1> %res to <16 x i8> + ret <16 x i8> %mask +; SSE2-LABEL: test_setcc_constfold_vi1: +; SSE2: pcmpeqd %xmm0, %xmm0 + +; SSE41-LABEL: test_setcc_constfold_vi1: +; SSE41: pcmpeqd %xmm0, %xmm0 + +; AVX-LABEL: test_setcc_constfold_vi1: +; AVX: vpcmpeqd %xmm0, %xmm0, %xmm0 +} + + +; 64-bit case is also particularly important, as the constant "-1" is probably +; just 32-bits wide. +define <2 x i64> @test_setcc_constfold_vi64(<2 x i64> %l, <2 x i64> %r) { + %test1 = icmp eq <2 x i64> %l, %r + %mask1 = sext <2 x i1> %test1 to <2 x i64> + + %test2 = icmp ne <2 x i64> %l, %r + %mask2 = sext <2 x i1> %test2 to <2 x i64> + + %res = or <2 x i64> %mask1, %mask2 + ret <2 x i64> %res +; SSE2-LABEL: test_setcc_constfold_vi64: +; SSE2: pcmpeqd %xmm0, %xmm0 + +; SSE41-LABEL: test_setcc_constfold_vi64: +; SSE41: pcmpeqd %xmm0, %xmm0 + +; AVX-LABEL: test_setcc_constfold_vi64: +; AVX: vpcmpeqd %xmm0, %xmm0, %xmm0 +}