RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-26 04:32:44 +01:00
Code Issues Projects Releases Wiki Activity

[llvm/DWARFDebugLine] Remove spurious full stop from warning messages

Browse Source 
Other warnings messages don't have a trailing full stop.
This commit is contained in:
Pavel Labath 2020-06-11 13:13:31 +02:00
parent 8e52bbf35f
commit 61de32a90c
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/DebugInfo/DWARF/DWARFDebugLine.cpp
View File

@ -275,14 +275,14 @@ parseV5DirFileTables(const DWARFDataExtractor &DebugLineData,
if (!Value.extractValue(DebugLineData, OffsetPtr, FormParams, &Ctx, U))
return createStringError(errc::invalid_argument,
"failed to parse directory entry because "
"extracting the form value failed.");
"extracting the form value failed");
IncludeDirectories.push_back(Value);
break;
default:
if (!Value.skipValue(DebugLineData, OffsetPtr, FormParams))
return createStringError(errc::invalid_argument,
"failed to parse directory entry because "
"skipping the form value failed.");
"skipping the form value failed");
}
}
}
@ -302,7 +302,7 @@ parseV5DirFileTables(const DWARFDataExtractor &DebugLineData,
if (!Value.extractValue(DebugLineData, OffsetPtr, FormParams, &Ctx, U))
return createStringError(errc::invalid_argument,
"failed to parse file entry because "
"extracting the form value failed.");
"extracting the form value failed");
switch (Descriptor.Type) {
case DW_LNCT_path:
FileEntry.Name = Value;

6
test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
View File

@ -161,7 +161,7 @@
## V5 prologue ends during directory table.
# NONFATAL: debug_line[0x00000214]
# SOME-ERR-NEXT: warning: parsing line table prologue at 0x00000214 found an invalid directory or file table description at 0x00000236
# SOME-ERR-NEXT: warning: failed to parse directory entry because extracting the form value failed.
# SOME-ERR-NEXT: warning: failed to parse directory entry because extracting the form value failed
# NONFATAL-NEXT: Line table prologue
# NONFATAL-NOT: include_directories
# VERBOSE: DW_LNE_set_address (0x4444333322221111)
@ -170,7 +170,7 @@
## V5 invalid MD5 hash form when there is still data to be read.
# NONFATAL: debug_line[0x00000244]
# SOME-ERR-NEXT: warning: parsing line table prologue at 0x00000244 found an invalid directory or file table description at 0x00000277
# SOME-ERR-NEXT: warning: failed to parse file entry because extracting the form value failed.
# SOME-ERR-NEXT: warning: failed to parse file entry because extracting the form value failed
# NONFATAL-NEXT: Line table prologue
# NONFATAL: include_directories[ 0] = "/tmp"
# NONFATAL-NOT: file_names
@ -190,7 +190,7 @@
## V5 invalid directory content description has unsupported form.
# NONFATAL: debug_line[0x000002c0]
# SOME-ERR-NEXT: warning: parsing line table prologue at 0x000002c0 found an invalid directory or file table description at 0x000002e9
# SOME-ERR-NEXT: warning: failed to parse directory entry because skipping the form value failed.
# SOME-ERR-NEXT: warning: failed to parse directory entry because skipping the form value failed
# NONFATAL-NEXT: Line table prologue
# NONFATAL: include_directories[ 0] = "/foo"
# NONFATAL-NOT: include_directories

2
unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp
View File

@ -472,7 +472,7 @@ TEST_P(DebugLineParameterisedFixture, ErrorForTooShortPrologueLength) {
"of the prologue");
} else {
Errs.emplace_back(
"failed to parse file entry because extracting the form value failed.");
"failed to parse file entry because extracting the form value failed");
}
EXPECT_THAT_ERROR(std::move(Recoverable),
FailedWithMessageArray(testing::ElementsAreArray(Errs)));