RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-22 02:33:06 +01:00
Code Issues Projects Releases Wiki Activity

[ADT] Follow up to fix bug in "Add makeVisitor to STLExtras.h"

Browse Source 
Address mistakenly comparing the pointer values of two C-style strings
rather than comparing their contents in the unit tests for makeVisitor,
added in 6d6f35eb7b92c6dd4478834497752f4e963db16d
This commit is contained in:
Scott Linder 2021-07-01 18:21:04 +00:00
parent ade0ec7fb0
commit 62d5b36f28
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
unittests/ADT/STLExtrasTest.cpp
View File

@ -777,9 +777,9 @@ TEST(STLExtrasTest, MakeVisitorOneCallable) {
TEST(STLExtrasTest, MakeVisitorTwoCallables) { TEST(STLExtrasTest, MakeVisitorTwoCallables) {
auto Visitor = auto Visitor =
makeVisitor([](int) { return "int"; }, [](std::string) { return "str"; }); makeVisitor([](int) { return 0; }, [](std::string) { return 1; });
EXPECT_EQ(Visitor(42), "int"); EXPECT_EQ(Visitor(42), 0);
EXPECT_EQ(Visitor("foo"), "str"); EXPECT_EQ(Visitor("foo"), 1);
} }
TEST(STLExtrasTest, MakeVisitorCallableMultipleOperands) { TEST(STLExtrasTest, MakeVisitorCallableMultipleOperands) {
@ -793,20 +793,20 @@ TEST(STLExtrasTest, MakeVisitorDefaultCase) {
{ {
auto Visitor = makeVisitor([](int I) { return I + 100; }, auto Visitor = makeVisitor([](int I) { return I + 100; },
[](float F) { return F * 2; }, [](float F) { return F * 2; },
[](auto) { return "unhandled type"; }); [](auto) { return -1; });
EXPECT_EQ(Visitor(24), 124); EXPECT_EQ(Visitor(24), 124);
EXPECT_EQ(Visitor(2.f), 4.f); EXPECT_EQ(Visitor(2.f), 4.f);
EXPECT_EQ(Visitor(2.), "unhandled type"); EXPECT_EQ(Visitor(2.), -1);
EXPECT_EQ(Visitor(Visitor), "unhandled type"); EXPECT_EQ(Visitor(Visitor), -1);
} }
{ {
auto Visitor = makeVisitor([](auto) { return "unhandled type"; }, auto Visitor = makeVisitor([](auto) { return -1; },
[](int I) { return I + 100; }, [](int I) { return I + 100; },
[](float F) { return F * 2; }); [](float F) { return F * 2; });
EXPECT_EQ(Visitor(24), 124); EXPECT_EQ(Visitor(24), 124);
EXPECT_EQ(Visitor(2.f), 4.f); EXPECT_EQ(Visitor(2.f), 4.f);
EXPECT_EQ(Visitor(2.), "unhandled type"); EXPECT_EQ(Visitor(2.), -1);
EXPECT_EQ(Visitor(Visitor), "unhandled type"); EXPECT_EQ(Visitor(Visitor), -1);
} }
} }