RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00
Code Issues Projects Releases Wiki Activity

Avoid some copies by using const references.

Browse Source 
clang-tidy's performance-unnecessary-copy-initialization with some manual
fixes. No functional changes intended.

llvm-svn: 270988
This commit is contained in:
Benjamin Kramer 2016-05-27 12:30:51 +00:00
parent f1afe1c451
commit 63c3e24c6a
13 changed files with 22 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Support/SpecialCaseList.cpp
View File

@ -50,7 +50,7 @@ std::unique_ptr<SpecialCaseList>
SpecialCaseList::create(const std::vector<std::string> &Paths,
std::string &Error) {
std::unique_ptr<SpecialCaseList> SCL(new SpecialCaseList());
for (auto Path : Paths) {
for (const auto &Path : Paths) {
ErrorOr<std::unique_ptr<MemoryBuffer>> FileOrErr =
MemoryBuffer::getFile(Path);
if (std::error_code EC = FileOrErr.getError()) {

4
lib/Target/AMDGPU/MCTargetDesc/AMDGPUAsmBackend.cpp
View File

@ -190,8 +190,6 @@ public:
MCAsmBackend *llvm::createAMDGPUAsmBackend(const Target &T,
const MCRegisterInfo &MRI,
const Triple &TT, StringRef CPU) {
Triple TargetTriple(TT);
// Use 64-bit ELF for amdgcn
return new ELFAMDGPUAsmBackend(T, TargetTriple.getArch() == Triple::amdgcn);
return new ELFAMDGPUAsmBackend(T, TT.getArch() == Triple::amdgcn);
}

2
lib/Target/ARM/ARMAsmPrinter.cpp
View File

@ -642,7 +642,7 @@ void ARMAsmPrinter::emitAttributes() {
static_cast<const ARMBaseTargetMachine &>(TM);
const ARMSubtarget STI(TT, CPU, ArchFS, ATM, ATM.isLittleEndian());
std::string CPUString = STI.getCPUString();
const std::string &CPUString = STI.getCPUString();
if (CPUString.find("generic") != 0) { //CPUString doesn't start with "generic"
// FIXME: remove krait check when GNU tools support krait cpu

1
lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp
View File

@ -1401,7 +1401,6 @@ bool HexagonAsmParser::parseInstruction(OperandVector &Operands) {
AsmToken const &Token = Parser.getTok();
if (Token.is(AsmToken::Identifier)) {
StringRef String = Token.getString();
AsmToken IDToken = Token;
if (String.lower() == "hi") {
HiOnly = true;
} else if (String.lower() == "lo") {

2
lib/Target/Mips/AsmParser/MipsAsmParser.cpp
View File

@ -438,7 +438,7 @@ public:
IsCpRestoreSet = false;
CpRestoreOffset = -1;
Triple TheTriple(sti.getTargetTriple());
const Triple &TheTriple = sti.getTargetTriple();
if ((TheTriple.getArch() == Triple::mips) ||
(TheTriple.getArch() == Triple::mips64))
IsLittleEndian = false;

2
lib/Target/NVPTX/NVPTXAsmPrinter.cpp
View File

@ -117,7 +117,7 @@ void NVPTXAsmPrinter::emitLineNumberAsDotLoc(const MachineInstr &MI) {
if (ignoreLoc(MI))
return;
DebugLoc curLoc = MI.getDebugLoc();
const DebugLoc &curLoc = MI.getDebugLoc();
if (!prevDebugLoc && !curLoc)
return;

2
lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp
View File

@ -292,7 +292,7 @@ public:
const MCInstrInfo &MII, const MCTargetOptions &Options)
: MCTargetAsmParser(Options, STI), MII(MII) {
// Check for 64-bit vs. 32-bit pointer mode.
Triple TheTriple(STI.getTargetTriple());
const Triple &TheTriple = STI.getTargetTriple();
IsPPC64 = (TheTriple.getArch() == Triple::ppc64 ||
TheTriple.getArch() == Triple::ppc64le);
IsDarwin = TheTriple.isMacOSX();

2
lib/Transforms/IPO/SampleProfile.cpp
View File

@ -445,7 +445,7 @@ void SampleProfileLoader::printBlockWeight(raw_ostream &OS,
/// \returns the weight of \p Inst.
ErrorOr<uint64_t>
SampleProfileLoader::getInstWeight(const Instruction &Inst) const {
DebugLoc DLoc = Inst.getDebugLoc();
const DebugLoc &DLoc = Inst.getDebugLoc();
if (!DLoc)
return std::error_code();

8
lib/Transforms/Utils/CodeExtractor.cpp
View File

@ -77,15 +77,15 @@ static SetVector<BasicBlock *> buildExtractionBlockSet(IteratorT BBBegin,
// Loop over the blocks, adding them to our set-vector, and aborting with an
// empty set if we encounter invalid blocks.
for (IteratorT I = BBBegin, E = BBEnd; I != E; ++I) {
if (!Result.insert(*I))
do {
if (!Result.insert(*BBBegin))
llvm_unreachable("Repeated basic blocks in extraction input");
if (!isBlockValidForExtraction(**I)) {
if (!isBlockValidForExtraction(**BBBegin)) {
Result.clear();
return Result;
}
}
} while (++BBBegin != BBEnd);
#ifndef NDEBUG
for (SetVector<BasicBlock *>::iterator I = std::next(Result.begin()),

2
tools/llvm-dwarfdump/llvm-dwarfdump.cpp
View File

@ -158,7 +158,7 @@ int main(int argc, char **argv) {
// Expand any .dSYM bundles to the individual object files contained therein.
std::vector<std::string> Objects;
for (auto F : InputFilenames) {
for (const auto &F : InputFilenames) {
auto Objs = expandBundle(F);
Objects.insert(Objects.end(), Objs.begin(), Objs.end());
}

14
tools/sancov/sancov.cc
View File

@ -894,7 +894,7 @@ public:
OS << "<table>\n";
OS << "<tr><th>File</th><th>Coverage %</th>";
OS << "<th>Hit (Total) Fns</th></tr>\n";
for (auto FileName : Files) {
for (const auto &FileName : Files) {
std::pair<size_t, size_t> FC = FileCoverage[FileName];
if (FC.first == 0) {
NotCoveredFilesCount++;
@ -915,7 +915,7 @@ public:
if (NotCoveredFilesCount) {
OS << "<details><summary>Not Touched Files</summary>\n";
OS << "<table>\n";
for (auto FileName : Files) {
for (const auto &FileName : Files) {
std::pair<size_t, size_t> FC = FileCoverage[FileName];
if (FC.first == 0)
OS << "<tr><td>" << stripPathPrefix(FileName) << "</td>\n";
@ -927,7 +927,7 @@ public:
}
// Source
for (auto FileName : Files) {
for (const auto &FileName : Files) {
std::pair<size_t, size_t> FC = FileCoverage[FileName];
if (FC.first == 0)
continue;
@ -969,7 +969,7 @@ public:
FileLoc Loc = FileLoc{FileName, Line};
auto It = AllFnsByLoc.find(Loc);
if (It != AllFnsByLoc.end()) {
for (std::string Fn : It->second) {
for (const std::string &Fn : It->second) {
OS << "<a name=\"" << anchorName(FileName + "::" + Fn)
<< "\"></a>";
};
@ -1069,7 +1069,7 @@ public:
std::vector<std::unique_ptr<CoverageDataWithObjectFile>> MergedCoverage;
for (const auto &Pair : CoverageByObjFile) {
if (findSanitizerCovFunctions(Pair.first).empty()) {
for (auto FileName : Pair.second) {
for (const auto &FileName : Pair.second) {
CovFiles.erase(FileName);
}
@ -1159,7 +1159,7 @@ public:
// About
OS << "<details><summary>About</summary>\n";
OS << "Coverage files:<ul>";
for (auto InputFile : CoverageFiles) {
for (const auto &InputFile : CoverageFiles) {
llvm::sys::fs::file_status Status;
llvm::sys::fs::status(InputFile, Status);
OS << "<li>" << stripPathPrefix(InputFile) << " ("
@ -1209,7 +1209,7 @@ int main(int argc, char **argv) {
return 0;
} else if (Action == PrintCovPointsAction) {
// -print-coverage-points doesn't need coverage files.
for (std::string ObjFile : ClInputFiles) {
for (const std::string &ObjFile : ClInputFiles) {
printCovPoints(ObjFile, outs());
}
return 0;

4
tools/yaml2obj/yaml2macho.cpp
View File

@ -116,7 +116,7 @@ template <>
size_t writeLoadCommandData<MachO::segment_command>(MachOYAML::LoadCommand &LC,
raw_ostream &OS) {
size_t BytesWritten = 0;
for (auto Sec : LC.Sections) {
for (const auto &Sec : LC.Sections) {
auto TempSec = constructSection<MachO::section>(Sec);
OS.write(reinterpret_cast<const char *>(&(TempSec)),
sizeof(MachO::section));
@ -130,7 +130,7 @@ size_t
writeLoadCommandData<MachO::segment_command_64>(MachOYAML::LoadCommand &LC,
raw_ostream &OS) {
size_t BytesWritten = 0;
for (auto Sec : LC.Sections) {
for (const auto &Sec : LC.Sections) {
auto TempSec = constructSection<MachO::section_64>(Sec);
TempSec.reserved3 = Sec.reserved3;
OS.write(reinterpret_cast<const char *>(&(TempSec)),

2
utils/TableGen/RegisterInfoEmitter.cpp
View File

@ -990,7 +990,7 @@ RegisterInfoEmitter::runMCDesc(raw_ostream &OS, CodeGenTarget &Target,
ArrayRef<Record*> Order = RC.getOrder();
// Give the register class a legal C name if it's anonymous.
std::string Name = RC.getName();
const std::string &Name = RC.getName();
RegClassStrings.add(Name);