mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 11:02:59 +02:00
[git-llvm] Check if svn is installed.
The error message that git-llvm script prints out when svn is missing is very cryptic. I spent a fair amount of time to find what was wrong with my environment. It looks like many newcomers also exprienced a hard time to submit their first patches due to this error. This patch adds a more user-friendly error message. Differential Revision: https://reviews.llvm.org/D33458 llvm-svn: 303696
This commit is contained in:
parent
a328f25e7f
commit
647132cc23
@ -133,6 +133,11 @@ def svn(cwd, *cmd, **kwargs):
|
|||||||
return shell(['svn'] + list(cmd), cwd=cwd, stdin=kwargs.get('stdin', None),
|
return shell(['svn'] + list(cmd), cwd=cwd, stdin=kwargs.get('stdin', None),
|
||||||
ignore_errors=kwargs.get('ignore_errors', None))
|
ignore_errors=kwargs.get('ignore_errors', None))
|
||||||
|
|
||||||
|
def program_exists(cmd):
|
||||||
|
for path in os.environ["PATH"].split(os.pathsep):
|
||||||
|
if os.access(os.path.join(path, cmd), os.X_OK):
|
||||||
|
return True
|
||||||
|
return False
|
||||||
|
|
||||||
def get_default_rev_range():
|
def get_default_rev_range():
|
||||||
# Get the branch tracked by the current branch, as set by
|
# Get the branch tracked by the current branch, as set by
|
||||||
@ -309,6 +314,9 @@ def cmd_push(args):
|
|||||||
|
|
||||||
|
|
||||||
if __name__ == '__main__':
|
if __name__ == '__main__':
|
||||||
|
if not program_exists('svn'):
|
||||||
|
die('error: git-llvm needs svn command, but svn is not installed.')
|
||||||
|
|
||||||
argv = sys.argv[1:]
|
argv = sys.argv[1:]
|
||||||
p = argparse.ArgumentParser(
|
p = argparse.ArgumentParser(
|
||||||
prog='git llvm', formatter_class=argparse.RawDescriptionHelpFormatter,
|
prog='git llvm', formatter_class=argparse.RawDescriptionHelpFormatter,
|
||||||
|
Loading…
Reference in New Issue
Block a user