RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-22 18:54:02 +01:00
Code Issues Projects Releases Wiki Activity

[MC] - Disallow invalid section groups declarations.

Browse Source 
This fixes parseGroup() so that it always sets error condition on error.
Previously it was not done, because parseIdentifier looks never do that,
assuming that caller should do it if he wants to.

So previously cases from test were silently accepted and produced broken output.

Differential revision: https://reviews.llvm.org/D41559

llvm-svn: 321439
This commit is contained in:
George Rimar 2017-12-25 09:41:00 +00:00
parent ee9e4fc042
commit 6481dde696
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/MC/MCParser/ELFAsmParser.cpp
View File

@ -427,13 +427,13 @@ bool ELFAsmParser::parseGroup(StringRef &GroupName) {
GroupName = getTok().getString();
Lex();
} else if (getParser().parseIdentifier(GroupName)) {
return true;
return TokError("invalid group name");
}
if (L.is(AsmToken::Comma)) {
Lex();
StringRef Linkage;
if (getParser().parseIdentifier(Linkage))
return true;
return TokError("invalid linkage");
if (Linkage != "comdat")
return TokError("Linkage must be 'comdat'");
}

14
test/MC/ELF/comdat-declaration-errors.s Normal file
View File

@ -0,0 +1,14 @@
// RUN: not llvm-mc -triple x86_64-pc-linux-gnu %s \
// RUN: -filetype=obj -o %t.o 2>&1 | FileCheck %s
// Check we error out on incorrect COMDATs declarations
// and not just silently ingnore them.
// CHECK: error: invalid group name
// CHECK-NEXT: .section .foo,"G",@progbits,-abc,comdat
// CHECK: error: invalid linkage
// CHECK-NEXT: .section .bar,"G",@progbits,abc,-comdat
.section .foo,"G",@progbits,-abc,comdat
.section .bar,"G",@progbits,abc,-comdat