1
0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-19 11:02:59 +02:00

[SelectionDAG]: Ignore "returned" in the presence of an implicit sret.

When a function return value can't be directly lowered, such as
returning an i128 on WebAssembly, as indicated by the CanLowerReturn
target hook, SelectionDAGBuilder can translate it to return the
value through a hidden sret-like argument.

If such a function has an argument with the "returned" attribute,
the attribute can't be automatically lowered, because the function
no longer has a normal return value. For now, just discard the
"returned" attribute.

This fixes PR36128.

llvm-svn: 323715
This commit is contained in:
Dan Gohman 2018-01-30 00:14:40 +00:00
parent 942f1d3e29
commit 675dc3c560
2 changed files with 24 additions and 2 deletions

View File

@ -8241,8 +8241,10 @@ TargetLowering::LowerCallTo(TargetLowering::CallLoweringInfo &CLI) const {
else if (Args[i].IsZExt)
ExtendKind = ISD::ZERO_EXTEND;
// Conservatively only handle 'returned' on non-vectors for now
if (Args[i].IsReturned && !Op.getValueType().isVector()) {
// Conservatively only handle 'returned' on non-vectors that can be lowered,
// for now.
if (Args[i].IsReturned && !Op.getValueType().isVector() &&
CanLowerReturn) {
assert(CLI.RetTy == Args[i].Ty && RetTys.size() == NumValues &&
"unexpected use of 'returned'");
// Before passing 'returned' to the target lowering code, ensure that

View File

@ -0,0 +1,20 @@
; RUN: llc < %s -asm-verbose=false | FileCheck %s
; Test that the "returned" attribute works with i128 types.
; PR36128
target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown-wasm"
declare i128 @bar(i128 returned)
define i128 @foo(i128) {
%r = tail call i128 @bar(i128 %0)
ret i128 %r
}
; CHECK-LABEL: foo:
; CHECK-NEXT: .param i32, i64, i64
; CHECK-NOT: .result
; CHECK: .functype bar, void, i32, i64, i64