RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00
Code Issues Projects Releases Wiki Activity

IR: Simplify two loops walking ConstantDataSequential, NFC

Browse Source 
Follow-up to b2b7cf39d596b1528cd64015575b3f5d1461c011.

Differential Revision: https://reviews.llvm.org/D90198
This commit is contained in:
Duncan P. N. Exon Smith 2020-10-26 19:03:23 -04:00
parent ded2243113
commit 6c9c96836e
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/IR/Constants.cpp
View File

@ -2784,10 +2784,9 @@ Constant *ConstantDataSequential::getImpl(StringRef Elements, Type *Ty) {
// of i8, or a 1-element array of i32. They'll both end up in the same
/// StringMap bucket, linked up by their Next pointers. Walk the list.
std::unique_ptr<ConstantDataSequential> *Entry = &Slot.second;
for (ConstantDataSequential *Node = Entry->get(); Node;
Entry = &Node->Next, Node = Entry->get())
if (Node->getType() == Ty)
return Node;
for (; *Entry; Entry = &(*Entry)->Next)
if ((*Entry)->getType() == Ty)
return Entry->get();
// Okay, we didn't get a hit. Create a node of the right class, link it in,
// and return it.
@ -2825,14 +2824,16 @@ void ConstantDataSequential::destroyConstantImpl() {
// Otherwise, there are multiple entries linked off the bucket, unlink the
// node we care about but keep the bucket around.
for (ConstantDataSequential *Node = Entry->get();;
Entry = &Node->Next, Node = Entry->get()) {
while (true) {
std::unique_ptr<ConstantDataSequential> &Node = *Entry;
assert(Node && "Didn't find entry in its uniquing hash table!");
// If we found our entry, unlink it from the list and we're done.
if (Node == this) {
*Entry = std::move(Node->Next);
if (Node.get() == this) {
Node = std::move(Node->Next);
return;
}
Entry = &Node->Next;
}
}