From 6fb4abf29d351b6392712de338bbad0ee84c768f Mon Sep 17 00:00:00 2001 From: Francis Visoiu Mistrih Date: Thu, 31 Oct 2019 15:50:00 -0700 Subject: [PATCH] [Remarks] Fix error message check in unit test Always compare using lowercase to support multiple platforms. --- unittests/Remarks/RemarksLinkingTest.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/unittests/Remarks/RemarksLinkingTest.cpp b/unittests/Remarks/RemarksLinkingTest.cpp index 8d38c6b1cdb..95c800d2d10 100644 --- a/unittests/Remarks/RemarksLinkingTest.cpp +++ b/unittests/Remarks/RemarksLinkingTest.cpp @@ -211,7 +211,9 @@ TEST(Remarks, LinkingError) { 40), remarks::Format::YAMLStrTab); EXPECT_TRUE(static_cast(E)); - EXPECT_EQ(toString(std::move(E)), - "'/baddir/badfile.opt.yaml': No such file or directory"); + std::string ErrorMessage = toString(std::move(E)); + EXPECT_EQ(StringRef(ErrorMessage).lower(), + StringRef("'/baddir/badfile.opt.yaml': No such file or directory") + .lower()); } }