RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 03:02:36 +01:00
Code Issues Projects Releases Wiki Activity

[SelectionDAG] Fix noop detection for vectors in AssertZext/AssertSext in getNode

Browse Source 
The assertion type is always supposed to be a scalar type. So if the result VT of the assertion is a vector, we need to get the scalar VT before we can compare them.

Similarly for the assert above it.

I don't have a test case because I don't know of any place we violate this today. A coworker found this while trying to use r347287 on the 6.0 branch without also having r336868

llvm-svn: 349390
This commit is contained in:
Craig Topper 2018-12-17 20:29:13 +00:00
parent f2def9239d
commit 722c971488
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/CodeGen/SelectionDAG/SelectionDAG.cpp
View File

@ -4842,8 +4842,8 @@ SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, EVT VT,
assert(!EVT.isVector() && assert(!EVT.isVector() &&
"AssertSExt/AssertZExt type should be the vector element type " "AssertSExt/AssertZExt type should be the vector element type "
"rather than the vector type!"); "rather than the vector type!");
assert(EVT.bitsLE(VT) && "Not extending!"); assert(EVT.bitsLE(VT.getScalarType()) && "Not extending!");
if (VT == EVT) return N1; // noop assertion. if (VT.getScalarType() == EVT) return N1; // noop assertion.
break; break;
} }
case ISD::SIGN_EXTEND_INREG: { case ISD::SIGN_EXTEND_INREG: {