RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 03:02:36 +01:00
Code Issues Projects Releases Wiki Activity

[DebugInfo] Print the actual value of an unknown section identifier.

Browse Source 
This is a follow-up for D75609. As @dblaikie suggested, it prints
the actual number for an unknown section identifier when dumping
unit index sections.

Differential Revision: https://reviews.llvm.org/D75668
This commit is contained in:
Igor Kudrin 2020-03-05 16:43:56 +07:00
parent 58cf96cd46
commit 75ae27f650
2 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/DebugInfo/DWARF/DWARFUnitIndex.cpp
View File

@ -118,7 +118,7 @@ StringRef DWARFUnitIndex::getColumnHeader(DWARFSectionKind DS) {
CASE(MACINFO);
CASE(MACRO);
}
return "<unknown>";
return StringRef();
}
void DWARFUnitIndex::dump(raw_ostream &OS) const {
@ -127,8 +127,14 @@ void DWARFUnitIndex::dump(raw_ostream &OS) const {
Header.dump(OS);
OS << "Index Signature ";
for (unsigned i = 0; i != Header.NumColumns; ++i)
OS << ' ' << left_justify(getColumnHeader(ColumnKinds[i]), 24);
for (unsigned i = 0; i != Header.NumColumns; ++i) {
DWARFSectionKind Kind = ColumnKinds[i];
StringRef Name = getColumnHeader(Kind);
if (!Name.empty())
OS << ' ' << left_justify(Name, 24);
else
OS << format(" Unknown: %-15u", static_cast<unsigned>(Kind));
}
OS << "\n----- ------------------";
for (unsigned i = 0; i != Header.NumColumns; ++i)
OS << " ------------------------";

14
test/DebugInfo/X86/debug-cu-index-unknown-section.s
View File

@ -1,11 +1,11 @@
# RUN: llvm-mc -triple x86_64-unknown-linux %s -filetype=obj -o - | \
# RUN: llvm-dwarfdump -debug-cu-index - | \
# RUN: FileCheck %s
# RUN: FileCheck %s --strict-whitespace
# CHECK: .debug_cu_index contents:
# CHECK-NEXT: version = 2 slots = 2
# CHECK-EMPTY:
# CHECK-NEXT: Index Signature INFO <unknown>
# CHECK-NEXT: Index Signature Unknown: 9 INFO
# CHECK-NEXT: ----- ------------------ ------------------------ ------------------------
# CHECK-NEXT: 1 0x1100001122222222 [0x00001000, 0x00001010) [0x00002000, 0x00002020)
@ -23,11 +23,11 @@
.long 0
## Table of Section Offsets:
## Row 0:
.long 9 # Unknown section identifier
.long 1 # DW_SECT_INFO
.long 9 # Invalid section identifier
## Row 1:
.long 0x1000 # Offset in .debug_info.dwo
.long 0x2000
.long 0x1000 # Offset in an unknown section
.long 0x2000 # Offset in .debug_info.dwo
## Table of Section Sizes:
.long 0x10 # Size in .debug_info.dwo
.long 0x20
.long 0x10 # Size in an unknown section
.long 0x20 # Size in .debug_info.dwo