RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-22 10:42:39 +01:00
Code Issues Projects Releases Wiki Activity

[APFloat] Fix IsInteger() for DoubleAPFloat.

Browse Source 
Previously, we would just assert instead.

Differential Revision:  https://reviews.llvm.org/D36961

llvm-svn: 311351
This commit is contained in:
Davide Italiano 2017-08-21 16:51:54 +00:00
parent 6bf02fc19f
commit 8194334bae
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Support/APFloat.cpp
View File

@ -4363,10 +4363,7 @@ bool DoubleAPFloat::isLargest() const {
bool DoubleAPFloat::isInteger() const {
assert(Semantics == &semPPCDoubleDouble && "Unexpected Semantics");
APFloat Tmp(semPPCDoubleDoubleLegacy);
(void)Tmp.add(Floats[0], rmNearestTiesToEven);
(void)Tmp.add(Floats[1], rmNearestTiesToEven);
return Tmp.isInteger();
return Floats[0].isInteger() && Floats[1].isInteger();
}
void DoubleAPFloat::toString(SmallVectorImpl<char> &Str,

18
unittests/ADT/APFloatTest.cpp
View File

@ -1349,6 +1349,24 @@ TEST(APFloatTest, isInteger) {
EXPECT_TRUE(T.isInteger());
}
TEST(DoubleAPFloatTest, isInteger) {
APFloat F1(-0.0);
APFloat F2(-0.0);
llvm::detail::DoubleAPFloat T(APFloat::PPCDoubleDouble(), std::move(F1),
std::move(F2));
EXPECT_TRUE(T.isInteger());
APFloat F3(3.14159);
APFloat F4(-0.0);
llvm::detail::DoubleAPFloat T2(APFloat::PPCDoubleDouble(), std::move(F3),
std::move(F4));
EXPECT_FALSE(T2.isInteger());
APFloat F5(-0.0);
APFloat F6(3.14159);
llvm::detail::DoubleAPFloat T3(APFloat::PPCDoubleDouble(), std::move(F5),
std::move(F6));
EXPECT_FALSE(T3.isInteger());
}
TEST(APFloatTest, getLargest) {
EXPECT_EQ(3.402823466e+38f, APFloat::getLargest(APFloat::IEEEsingle()).convertToFloat());
EXPECT_EQ(1.7976931348623158e+308, APFloat::getLargest(APFloat::IEEEdouble()).convertToDouble());