RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 12:41:49 +01:00
Code Issues Projects Releases Wiki Activity

Verifier: Forbid comdats on linker declarations.

Browse Source 
Differential Revision: http://reviews.llvm.org/D10945

llvm-svn: 241414
This commit is contained in:
Peter Collingbourne 2015-07-05 20:52:40 +00:00
parent f49ef7d3ac
commit 81c161f9de
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/IR/Verifier.cpp
View File

@ -438,6 +438,9 @@ void Verifier::visitGlobalValue(const GlobalValue &GV) {
Assert(GVar && GVar->getValueType()->isArrayTy(),
"Only global arrays can have appending linkage!", GVar);
}
if (GV.isDeclarationForLinker())
Assert(!GV.hasComdat(), "Declaration may not be in a Comdat!", &GV);
}
void Verifier::visitGlobalVariable(const GlobalVariable &GV) {

5
test/Verifier/comdat-decl1.ll Normal file
View File

@ -0,0 +1,5 @@
; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s
$v = comdat any
@v = available_externally global i32 0, comdat
; CHECK: Declaration may not be in a Comdat!

5
test/Verifier/comdat-decl2.ll Normal file
View File

@ -0,0 +1,5 @@
; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s
$v = comdat any
@v = external global i32, comdat
; CHECK: Declaration may not be in a Comdat!