mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 18:54:02 +01:00
[X86] Fix emitPrologue() to make less assumptions about pushes
When X86FrameLowering::emitPrologue() looks for where to insert the %esp subtraction to allocate stack space for local allocations, it assumes that any sequence of push instructions that starts at function entry consists purely of spills of callee-save registers. This may be false, since from some point forward, the pushes may pushing arguments to a subsequent function call. This caused a miscompile that was exposed by r240257, and is not easily testable since r240257 was reverted. A test will be committed separately after r240257 is reapplied. llvm-svn: 242395
This commit is contained in:
parent
4b4fdbde84
commit
840734f4bb
@ -794,6 +794,7 @@ void X86FrameLowering::emitPrologue(MachineFunction &MF,
|
||||
int StackOffset = 2 * stackGrowth;
|
||||
|
||||
while (MBBI != MBB.end() &&
|
||||
MBBI->getFlag(MachineInstr::FrameSetup) &&
|
||||
(MBBI->getOpcode() == X86::PUSH32r ||
|
||||
MBBI->getOpcode() == X86::PUSH64r)) {
|
||||
PushedRegs = true;
|
||||
|
Loading…
Reference in New Issue
Block a user