From 89dee120a15d19fb400aded0564fdcf38796421e Mon Sep 17 00:00:00 2001 From: Owen Anderson Date: Wed, 31 Oct 2007 21:04:18 +0000 Subject: [PATCH] Add a preverifier pass to check that every basic block ends in a terminator, so that we don't segfault when verifying invalid code. llvm-svn: 43578 --- lib/VMCore/Verifier.cpp | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/lib/VMCore/Verifier.cpp b/lib/VMCore/Verifier.cpp index 68c30bbc638..afb90d44566 100644 --- a/lib/VMCore/Verifier.cpp +++ b/lib/VMCore/Verifier.cpp @@ -71,7 +71,25 @@ namespace { // Anonymous namespace for class cl::opt Pedantic("verify-pedantic", cl::desc("Reject code with undefined behaviour")); - + + struct VISIBILITY_HIDDEN PreVerifier : public FunctionPass { + static char ID; // Pass ID, replacement for typeid + + PreVerifier() : FunctionPass((intptr_t)&ID) { } + + bool runOnFunction(Function &F) { + for (Function::iterator I = F.begin(), E = F.end(); I != E; ++I) + assert(I->back().isTerminator() + && "Block does not end with a terminator?"); + + return false; + } + }; + + char PreVerifier::ID = 0; + RegisterPass PreVer("preverify", "Preliminary module verification"); + const PassInfo *PreVerifyID = PreVer.getPassInfo(); + struct VISIBILITY_HIDDEN Verifier : public FunctionPass, InstVisitor { static char ID; // Pass ID, replacement for typeid @@ -161,6 +179,7 @@ namespace { // Anonymous namespace for class virtual void getAnalysisUsage(AnalysisUsage &AU) const { AU.setPreservesAll(); + AU.addRequiredID(PreVerifyID); if (RealPass) AU.addRequired(); }