1
0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-25 04:02:41 +01:00

[obj2yaml] Address D104035 review comments

Accidentally missed from commit 5c1639fe064b.

Differential Revision: https://reviews.llvm.org/D104035
This commit is contained in:
James Henderson 2021-06-16 14:57:44 +01:00
parent 53635563ca
commit 8beee28e98
3 changed files with 4 additions and 4 deletions

View File

@ -1923,7 +1923,7 @@ bool ELFState<ELFT>::writeELF(raw_ostream &OS, ELFYAML::Object &Doc,
return false;
// Build the section index, which adds sections to the section header string
// table first, so that we can finalise the section header string table.
// table first, so that we can finalize the section header string table.
State.buildSectionIndex();
State.buildSymbolIndexes();

View File

@ -23,8 +23,8 @@ FileHeader:
Type: ET_EXEC
SectionHeaderStringTable: .foo
## Show the case when the e_shstrndx value is 0 and the name is not ".shstrtab"
## (the key should be set).
## Show the case when the e_shstrndx value is SHN_XINDEX and the name is not
## ".shstrtab" (the key should be set).
# RUN: yaml2obj --docnum=2 %s -o %t2.o
# RUN: obj2yaml %t2.o > %t2.yaml
# RUN: FileCheck %s --input-file=%t2.yaml --check-prefix=XINDEX

View File

@ -517,7 +517,7 @@ Optional<DWARFYAML::Data> ELFDumper<ELFT>::dumpDWARFSections(
if (ELFYAML::RawContentSection *RawSec =
dyn_cast<ELFYAML::RawContentSection>(C.get())) {
// FIXME: The debugDebug* functions should take the content as stored in
// FIXME: The dumpDebug* functions should take the content as stored in
// RawSec. Currently, they just use the last section with the matching
// name, which defeats this attempt to skip reading a section header
// string table with the same name as a DWARF section.