RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-22 10:42:39 +01:00
Code Issues Projects Releases Wiki Activity

[MSAN] Never allow checking calls to __sanitizer_unaligned_{load,store}

Browse Source 
These functions expect the caller to always pass shadows over TLS.

Differential Revision: https://reviews.llvm.org/D84351
This commit is contained in:
Gui Andrade 2020-07-23 16:36:19 +00:00
parent b85e3d578d
commit 8c1506c928
2 changed files with 38 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/Transforms/Instrumentation/MemorySanitizer.cpp
View File

@ -3551,6 +3551,12 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> {
maybeMarkSanitizerLibraryCallNoBuiltin(Call, TLI);
}
IRBuilder<> IRB(&CB);
bool MayCheckCall = ClEagerChecks;
if (Function *Func = CB.getCalledFunction()) {
// __sanitizer_unaligned_{load,store} functions may be called by users
// and always expects shadows in the TLS. So don't check them.
MayCheckCall &= !Func->getName().startswith("__sanitizer_unaligned_");
}
unsigned ArgOffset = 0;
LLVM_DEBUG(dbgs() << " CallSite: " << CB << "\n");
@ -3576,7 +3582,7 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> {
bool ByVal = CB.paramHasAttr(i, Attribute::ByVal);
bool NoUndef = CB.paramHasAttr(i, Attribute::NoUndef);
bool EagerCheck = ClEagerChecks && !ByVal && NoUndef;
bool EagerCheck = MayCheckCall && !ByVal && NoUndef;
if (EagerCheck) {
insertShadowCheck(A, &CB);
@ -3632,7 +3638,7 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> {
if (isa<CallInst>(CB) && cast<CallInst>(CB).isMustTailCall())
return;
if (ClEagerChecks && CB.hasRetAttr(Attribute::NoUndef)) {
if (MayCheckCall && CB.hasRetAttr(Attribute::NoUndef)) {
setShadow(&CB, getCleanShadow(&CB));
setOrigin(&CB, getCleanOrigin());
return;

30
test/Instrumentation/MemorySanitizer/no-check-rt-unaligned.ll Normal file
View File

@ -0,0 +1,30 @@
; RUN: opt < %s -msan-eager-checks -msan-check-access-address=0 -S -passes=msan 2>&1 | FileCheck %s
; RUN: opt < %s -msan-eager-checks -msan-check-access-address=0 -msan-track-origins=2 -S -passes=msan 2>&1 | FileCheck %s -check-prefixes=CHECK,CHECK-ORIGIN
; RUN: opt < %s -msan-eager-checks -msan -msan-check-access-address=0 -S | FileCheck %s
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
declare noundef i8 @__sanitizer_unaligned_load8(i8* noundef)
declare void @__sanitizer_unaligned_store8(i8* noundef, i8 noundef)
define noundef i8 @unaligned_load(i8* noundef %ptr) sanitize_memory {
; CHECK: @unaligned_load(i8* {{.*}}[[PTR:%.+]])
; CHECK: store i64 0, {{.*}} @__msan_param_tls
; CHECK: [[VAL:%.*]] = call noundef i8 @__sanitizer_unaligned_load8(i8* noundef [[PTR]])
%val = call noundef i8 @__sanitizer_unaligned_load8(i8* noundef %ptr)
; CHECK: load {{.*}} @__msan_retval_tls
; CHECK-ORIGIN: load {{.*}} @__msan_retval_origin_tls
; CHECK: call void @__msan_warning_{{.*}}noreturn
; CHECK: ret i8 [[VAL]]
ret i8 %val
}
define void @unaligned_store(i8* noundef %ptr, i8 noundef %val) sanitize_memory {
; CHECK: @unaligned_store(i8* {{.*}}[[PTR:%.+]], i8 {{.*}}[[VAL:%.+]])
; CHECK: store i64 0, {{.*}} @__msan_param_tls
; CHECK: store i8 0, {{.*}} @__msan_param_tls
; CHECK: call void @__sanitizer_unaligned_store8(i8* noundef [[PTR]], i8 noundef [[VAL]])
call void @__sanitizer_unaligned_store8(i8* noundef %ptr, i8 noundef %val)
; CHECK: ret void
ret void
}