From 8cb5aa0766f2e2905fa52b2b820f61c17d8c02b1 Mon Sep 17 00:00:00 2001 From: Sanjoy Das Date: Thu, 5 Nov 2015 01:53:26 +0000 Subject: [PATCH] [IR] Add bounds checking to dataOperandHasImpliedAttr This is similar to the bounds check added to paramHasAttr in r252073. llvm-svn: 252130 --- lib/IR/Instructions.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/IR/Instructions.cpp b/lib/IR/Instructions.cpp index 7c3695b1531..dfd711f5c23 100644 --- a/lib/IR/Instructions.cpp +++ b/lib/IR/Instructions.cpp @@ -343,6 +343,10 @@ bool CallInst::paramHasAttr(unsigned i, Attribute::AttrKind A) const { bool CallInst::dataOperandHasImpliedAttr(unsigned i, Attribute::AttrKind A) const { + // There are getNumOperands() - 1 data operands. The last operand is the + // callee. + assert(i < getNumOperands() && "Data operand index out of bounds!"); + // The attribute A can either be directly specified, if the operand in // question is a call argument; or be indirectly implied by the kind of its // containing operand bundle, if the operand is a bundle operand. @@ -603,6 +607,10 @@ bool InvokeInst::paramHasAttr(unsigned i, Attribute::AttrKind A) const { bool InvokeInst::dataOperandHasImpliedAttr(unsigned i, Attribute::AttrKind A) const { + // There are getNumOperands() - 3 data operands. The last three operands are + // the callee and the two successor basic blocks. + assert(i < (getNumOperands() - 2) && "Data operand index out of bounds!"); + // The attribute A can either be directly specified, if the operand in // question is an invoke argument; or be indirectly implied by the kind of its // containing operand bundle, if the operand is a bundle operand.