RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-24 11:42:57 +01:00
Code Issues Projects Releases Wiki Activity

This little patch speeds up the loop used to update the dominator set analysis.

Browse Source 
On the testcase from GCC PR12440, which has a LOT of loops (1392 of which require
preheaders to be inserted), this speeds up the loopsimplify pass from 1.931s to
0.1875s.  The loop in question goes from 1.65s -> 0.0097s, which isn't bad. All of
these times are a debug build.

This adds a dependency on DominatorTree analysis that was not there before, but
we always had dominatortree available anyway, because LICM requires both loop
simplify and DT, so this doesn't add any extra analysis in practice.

llvm-svn: 12362
This commit is contained in:
Chris Lattner 2004-03-13 22:01:26 +00:00
parent 228bd4e931
commit 8d45aeaff1
1 changed files with 18 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
lib/Transforms/Scalar/LoopSimplify.cpp
View File

@ -56,6 +56,7 @@ namespace {
// We need loop information to identify the loops...
AU.addRequired<LoopInfo>();
AU.addRequired<DominatorSet>();
AU.addRequired<DominatorTree>();
AU.addPreserved<LoopInfo>();
AU.addPreserved<DominatorSet>();
@ -279,6 +280,9 @@ void LoopSimplify::InsertPreheaderForLoop(Loop *L) {
ChangeExitBlock(*ParentLoops, Header, NewBB);
DominatorSet &DS = getAnalysis<DominatorSet>(); // Update dominator info
DominatorTree &DT = getAnalysis<DominatorTree>();
DominatorTree::Node *HeaderDTNode = DT.getNode(Header);
{
// The blocks that dominate NewBB are the blocks that dominate Header,
// minus Header, plus NewBB.
@ -288,10 +292,20 @@ void LoopSimplify::InsertPreheaderForLoop(Loop *L) {
DS.addBasicBlock(NewBB, DomSet);
// The newly created basic block dominates all nodes dominated by Header.
for (Function::iterator I = Header->getParent()->begin(),
E = Header->getParent()->end(); I != E; ++I)
if (DS.dominates(Header, I))
DS.addDominator(I, NewBB);
for (DominatorTree::Node::iterator I = HeaderDTNode->begin(),
E = HeaderDTNode->end(); I != E; ++I)
DS.addDominator((*I)->getBlock(), NewBB);
}
{ // Update the dominator tree information.
// The immediate dominator of the preheader is the immediate dominator of
// the old header.
//
DominatorTree::Node *PHNode =
DT.createNewNode(NewBB, HeaderDTNode->getIDom());
// Change the header node so that PNHode is the new immediate dominator
DT.changeImmediateDominator(HeaderDTNode, PHNode);
}
// Update immediate dominator information if we have it...
@ -303,19 +317,6 @@ void LoopSimplify::InsertPreheaderForLoop(Loop *L) {
ID->setImmediateDominator(Header, NewBB);
}
// Update DominatorTree information if it is active.
if (DominatorTree *DT = getAnalysisToUpdate<DominatorTree>()) {
// The immediate dominator of the preheader is the immediate dominator of
// the old header.
//
DominatorTree::Node *HeaderNode = DT->getNode(Header);
DominatorTree::Node *PHNode = DT->createNewNode(NewBB,
HeaderNode->getIDom());
// Change the header node so that PNHode is the new immediate dominator
DT->changeImmediateDominator(HeaderNode, PHNode);
}
// Update dominance frontier information...
if (DominanceFrontier *DF = getAnalysisToUpdate<DominanceFrontier>()) {
// The DF(NewBB) is just (DF(Header)-Header), because NewBB dominates