RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-19 19:12:56 +02:00
Code Issues Projects Releases Wiki Activity

[NFC] Pre-calculate basic block IR counts in size remarks.

Browse Source 
Size remarks are slow due to lots of recalculation of the module.

This is similar to the previous commit. Cache the size of the module and
update counts in basic block passes based off a less-expensive delta.

2/6

llvm-svn: 341246
This commit is contained in:
Jessica Paquette 2018-08-31 20:20:53 +00:00
parent 576c480097
commit 8e00273b91
1 changed files with 21 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
lib/IR/LegacyPassManager.cpp
View File

@ -1287,9 +1287,15 @@ bool BBPassManager::runOnFunction(Function &F) {
bool Changed = doInitialization(F);
Module &M = *F.getParent();
unsigned InstrCount = 0;
unsigned InstrCount, BBSize = 0;
bool EmitICRemark = M.shouldEmitInstrCountChangedRemark();
for (BasicBlock &BB : F)
if (EmitICRemark)
InstrCount = initSizeRemarkInfo(M);
for (BasicBlock &BB : F) {
// Collect the initial size of the basic block.
if (EmitICRemark)
BBSize = BB.size();
for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
BasicBlockPass *BP = getContainedPass(Index);
bool LocalChanged = false;
@ -1303,11 +1309,19 @@ bool BBPassManager::runOnFunction(Function &F) {
// If the pass crashes, remember this.
PassManagerPrettyStackEntry X(BP, BB);
TimeRegion PassTimer(getPassTimer(BP));
if (EmitICRemark)
InstrCount = initSizeRemarkInfo(M);
LocalChanged |= BP->runOnBasicBlock(BB);
if (EmitICRemark)
emitInstrCountChangedRemark(BP, M, InstrCount);
if (EmitICRemark) {
unsigned NewSize = BB.size();
// Update the size of the basic block, emit a remark, and update the
// size of the module.
if (NewSize != BBSize) {
emitInstrCountChangedRemark(BP, M, InstrCount);
int64_t Delta =
static_cast<int64_t>(NewSize) - static_cast<int64_t>(BBSize);
InstrCount = static_cast<int64_t>(InstrCount) + Delta;
BBSize = NewSize;
}
}
}
Changed |= LocalChanged;
@ -1322,6 +1336,7 @@ bool BBPassManager::runOnFunction(Function &F) {
recordAvailableAnalysis(BP);
removeDeadPasses(BP, BB.getName(), ON_BASICBLOCK_MSG);
}
}
return doFinalization(F) || Changed;
}