1
0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-20 19:42:54 +02:00

Pass the error string directly to llvm_unreachable instead of the residual

(0 && "error").  Rough consensus seems to be that g++ *should* be diagnosing
this because the pointer makes it not an ICE in c++03.  Everyone agrees that
the current standard is silly and null-pointer-ness should not be based on
ICE-ness.  Excellent fight scene in Act II, denouement weak, two stars.

llvm-svn: 91644
This commit is contained in:
John McCall 2009-12-18 00:27:18 +00:00
parent b39930cf6d
commit 923cb2d8d7

View File

@ -34,7 +34,7 @@ GetGlobalAddressSymbol(const MachineOperand &MO) const {
Mang.getNameWithPrefix(Name, GV, false); Mang.getNameWithPrefix(Name, GV, false);
switch (MO.getTargetFlags()) { switch (MO.getTargetFlags()) {
default: llvm_unreachable(0 && "Unknown target flag on GV operand"); default: llvm_unreachable("Unknown target flag on GV operand");
case 0: break; case 0: break;
} }